Bugzilla – Attachment 34092 Details for
Bug 13375
Syspref search highlight styling broken in Chrome
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome
Bug-13375-Alternate-Syspref-search-highlight-styli.patch (text/plain), 1.76 KB, created by
Owen Leonard
on 2014-12-03 13:45:21 UTC
(
hide
)
Description:
Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-12-03 13:45:21 UTC
Size:
1.76 KB
patch
obsolete
>From 889de7851f7f38c3c0d68aa5836b05be859032c7 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Dec 2014 08:36:04 -0500 >Subject: [PATCH] Bug 13375 [Alternate] Syspref search highlight styling > broken in Chrome >Content-Type: text/plain; charset="utf-8" > >This patch encloses the the syspref description/values mix in a <div>. >It doesn't introduce any regression on other browsers (like Firefox) and >has the side effect to make Chrome render the highlighted words on >syspref searches well. > >This alternate patch uses a <div> instead of a <span> because it will >sometimes contain block-level elements. Follow the same plan: > >To test: >- Search for 'facet' on the sysprefs >=> FAIL: verify it has styling problems in Chrome >- Apply the patch, reload >=> SUCCESS: styling is correct >--- > .../prog/en/modules/admin/preferences.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index dde4764..23befab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -110,7 +110,7 @@ > [% END %] > </code> > </td> >- <td> >+ <td><div> > [% FOREACH CHUNK IN LINE.CHUNKS %] > [% IF ( CHUNK.type_text ) %] > [% CHUNK.contents %] >@@ -166,7 +166,7 @@ > </dl> > [% END %] > [% END %] >- </td> >+ </div></td> > </tr> > [% IF ( loop.last ) %]</tbody></table>[% END %] > [% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13375
:
34075
|
34076
|
34077
|
34092
|
34093
|
34144