Bugzilla – Attachment 36777 Details for
Bug 13423
Unused code in serials-edit.tt and serials-recieve.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt
Signed-off-Bug-13423-Untranslatable-strings-in-ser.patch (text/plain), 3.71 KB, created by
Marc Véron
on 2015-03-10 17:54:28 UTC
(
hide
)
Description:
[Signed-off] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-03-10 17:54:28 UTC
Size:
3.71 KB
patch
obsolete
>From 94a60c3940a46b2012b553862196255a98008abf Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Sat, 7 Mar 2015 14:16:13 -0300 >Subject: [PATCH] [Signed-off] Bug 13423: Untranslatable strings in > serials-edit.tt and serials-recieve.tt >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Thid patch rewrites strings to make them translatable > >To test: >1) Apply the patch >2) Update translation for your language of choice >3) Check new strings on staff PO file >+msgid "A barcode was not entered." >+msgid "Do you want to put in a barcode" >+msgid "Leave barcode blank?" >+msgid "Note: unable to change this later" >+msgid "or do you want to use a system generated barcode?" > >Followed test plan. Strings appeared in staff PO file as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 3877715..0cc7382 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -28,7 +28,7 @@ function barcode_check(){ > // alert(elembarcode+"\n"+eval(elembarcode+".value)); > // alert(elemstatus+"\n"+eval(elemstatus+".value")); > if(eval(elembarcode+".value") =='' && eval(elemstatus+".value") == 2){ >- var answer = confirm("Leave barcode blank?\n - Note: unable to change this later"); >+ var answer = confirm(_("Leave barcode blank?")+"\n"+_("Note: unable to change this later")); > if (answer){ > document.f.submit(); > } else { >@@ -36,7 +36,7 @@ function barcode_check(){ > } > } > if(eval(elembarcode+".value".indexOf('TEMP')) > 0 && eval(elemstatus+".value") == 2){ >- var answer = confirm("A barcode was not entered.\nDo you want to put in a barcode\nor do you want to use a system generated barcode?"); >+ var answer = confirm(_("A barcode was not entered.")+"\n"+_("Do you want to put in a barcode")+"\n"+_("or do you want to use a system generated barcode?")); > if (answer){ > document.f.submit(); > } else { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >index f93c8c7..d35efa1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >@@ -19,7 +19,7 @@ function barcode_check(){ > // alert(elembarcode+"\n"+eval(elembarcode+".value)); > // alert(elemstatus+"\n"+eval(elemstatus+".value")); > if(eval(elembarcode+".value") =='' && eval(elemstatus+".value") == 2){ >- var answer = confirm("Leave barcode blank?\n - Note: unable to change this later"); >+ var answer = confirm(_("Leave barcode blank?")+"\n"+_("Note: unable to change this later")); > if (answer){ > document.f.submit(); > } else { >@@ -27,7 +27,7 @@ function barcode_check(){ > } > } > if(eval(elembarcode+".value".indexOf('TEMP')) > 0 && eval(elemstatus+".value") == 2){ >- var answer = confirm("A barcode was not entered.\nDo you want to put in a barcode\nor do you want to use a system generated barcode?"); >+ var answer = confirm(_("A barcode was not entered.")+"\n"+_("Do you want to put in a barcode")+"\n"+_("or do you want to use a system generated barcode?")); > if (answer){ > document.f.submit(); > } else { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13423
:
36727
|
36777
|
37196
|
37197
|
37435
|
38508
|
38647
|
38648
|
38649
|
38703
|
38704
|
38705