git grep 'confirm("' Result: 2 untranslatable stings in: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt 2 untranslatable strings in: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Should perhaps also grep for "confirm('", which returns different results...
Hi paxed, I did, some of the outcome is waiting for Sign-off: Bug 13400 Bug 13410 Bug 13422 Marc
Created attachment 36727 [details] [review] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt Thid patch rewrites strings to make them translatable To test: 1) Apply the patch 2) Update translation for your language of choice 3) Check new strings on staff PO file +msgid "A barcode was not entered." +msgid "Do you want to put in a barcode" +msgid "Leave barcode blank?" +msgid "Note: unable to change this later" +msgid "or do you want to use a system generated barcode?"
Created attachment 36777 [details] [review] [Signed-off] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt Thid patch rewrites strings to make them translatable To test: 1) Apply the patch 2) Update translation for your language of choice 3) Check new strings on staff PO file +msgid "A barcode was not entered." +msgid "Do you want to put in a barcode" +msgid "Leave barcode blank?" +msgid "Note: unable to change this later" +msgid "or do you want to use a system generated barcode?" Followed test plan. Strings appeared in staff PO file as expected. Signed-off-by: Marc Véron <veron@veron.ch>
I have no problem with these fixes, but I wonder how to trigger the messages. I didn't manage to - is this code still in use? Please check and amend test plan - thx!
(In reply to Katrin Fischer from comment #5) > I have no problem with these fixes, but I wonder how to trigger the > messages. I didn't manage to - is this code still in use? > Please check and amend test plan - thx! Hehe :) I don't put better instructions because I down't know either how to trigger the messages I'll check!
Created attachment 37196 [details] [review] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected http://bugs.koha-community.org/show_bug.cgi?id=13424
Created attachment 37197 [details] [review] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected
Created attachment 37435 [details] [review] Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the <!--onsubmit="return barcode_check()">--> $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
The only non-obsoleted patch no long makes the strings in serials-recieve.tt translatable.
Created attachment 38508 [details] [review] Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()"> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f2" action="serials-recieve.pl"> serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted
(In reply to Kyle M Hall from comment #10) > The only non-obsoleted patch no long makes the strings in serials-recieve.tt > translatable. It's also dead code. Followup removes the file. Second patch needs sign.
Created attachment 38647 [details] [review] Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the <!--onsubmit="return barcode_check()">--> $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 38648 [details] [review] Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()"> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f2" action="serials-recieve.pl"> serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 38649 [details] [review] Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I took the liberty to edit the commit message of the first patch.
Created attachment 38703 [details] [review] [PASSED QA] Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the <!--onsubmit="return barcode_check()">--> $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38704 [details] [review] [PASSED QA] Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()"> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f2" action="serials-recieve.pl"> serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38705 [details] [review] [PASSED QA] Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Parches aplicados en master. Gracias Bernardo!
Pushed to 3.18.x will be in 3.18.7
Possible selection for 3.16.x