Bugzilla – Attachment 42840 Details for
Bug 14872
Reminder to update SMSnumber when primary phone is updated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14872: Reminder to update SMSnumber when primary phone is updated
Bug-14872-Reminder-to-update-SMSnumber-when-primar.patch (text/plain), 4.86 KB, created by
Lari Taskula
on 2015-09-24 11:22:24 UTC
(
hide
)
Description:
Bug 14872: Reminder to update SMSnumber when primary phone is updated
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2015-09-24 11:22:24 UTC
Size:
4.86 KB
patch
obsolete
>From fb89db16328d667bd65ae2fd76f1e7cbb20ec571 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <larit@student.uef.fi> >Date: Thu, 24 Sep 2015 13:17:39 +0300 >Subject: [PATCH] Bug 14872: Reminder to update SMSnumber when primary phone is > updated > >Since SMS number (smsalertnumber) and primary phone are separated, it would >be useful to remind patron to update his/her SMS number when making changes >to primary phone. This can easily be forgotten, especially in OPAC where the >two fields are in different page (opac-memberentry.pl vs opac-messaging.pl). > >This patch adds a reminder in the "hint"-div that activates whenever phone >field gets input (and phone-smsalertnumber do not match). > >To test: >1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences >2. Navigate to OPAC -> your personal details >3. Input something to primary phone. You should not be notified at all >4. Navigate to Intra -> Patron -> Edit >5. Repeat step 3 >6. Apply patch >7. Refresh Opac -> your personal details and Intra -> Patron -> Edit >8. Input something to primary phone and observe you will be notified to > also update SMS number. >--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 13 ++++++++++++- > .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 12 ++++++++++++ > opac/opac-memberentry.pl | 1 + > 3 files changed, 25 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 56b58e8..dc59b42 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -72,6 +72,17 @@ > mrform.hide(); > e.preventDefault(); > }); >+ [% IF (SMSSendDriver ) %] >+ $("#phone").on("input",function(e){ >+ if ($(this).val() != $("#SMSnumber").val()){ >+ $("#phone-reminder").css("display", "block"); >+ } else { >+ if ($("#phone-reminder").css("display") == "block") { >+ $("#phone-reminder").css("display", "none"); >+ } >+ } >+ }); >+ [% END %] > }); > > function clear_entry(node) { >@@ -513,7 +524,7 @@ > [% END %] > Primary phone: </label> > <input type="text" id="phone" name="phone" value="[% phone %]" /> >- [% IF ( mandatoryphone ) %]<span class="required">Required</span>[% END %]<div class="hint">Shows on transit slips</div> >+ [% IF ( mandatoryphone ) %]<span class="required">Required</span>[% END %]<div class="hint">Shows on transit slips[% IF ( SMSSendDriver ) %]<div id="phone-reminder" style="display:none;"><strong>Remember to also update <span onclick="$('#SMSnumber').focus()" style="text-decoration:underline;cursor:pointer;">SMS number</span> if needed.</strong></div>[% END %]</div> > > </li> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index ca35988..b3e76ea 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -397,6 +397,7 @@ > > <input type="text" id="borrower_phone" name="borrower_phone" value="[% borrower.phone %]" /> > [% IF mandatory.defined('phone') %]<span class="required">Required</span>[% END %] >+ [% IF ( SMSSendDriver ) %]<div class="hint"><div id="phone-reminder" style="display:none;"><strong>Remember to also update <a href="opac-messaging.pl" target="_blank">SMS number</a> if needed (optional).</strong></div></div>[% END %] > </li> > [% END %] > >@@ -853,6 +854,17 @@ > error.css('width', 'auto'); > } > }); >+ [% IF (SMSSendDriver ) %] >+ $("#borrower_phone").on("input",function(e){ >+ if ($(this).val() != "[% borrower.phone %]"){ >+ $("#phone-reminder").css("display", "block"); >+ } else { >+ if ($("#phone-reminder").css("display") == "block") { >+ $("#phone-reminder").css("display", "none"); >+ } >+ } >+ }); >+ [% END %] > }); > //]]> > </script> >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index f696208..b34366a 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -68,6 +68,7 @@ $template->param( > member_titles => GetTitles() || undef, > branches => GetBranchesLoop(), > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), >+ SMSSendDriver => C4::Context->preference('SMSSendDriver'), > ); > > if ( $action eq 'create' ) { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14872
:
42840
|
42841
|
47624