Bug 14872 - Reminder to update SMSnumber when primary phone is updated
Summary: Reminder to update SMSnumber when primary phone is updated
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lari Taskula
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-22 14:11 UTC by Lari Taskula
Modified: 2017-03-17 21:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14872: Reminder to update SMSnumber when primary phone is updated (4.86 KB, patch)
2015-09-24 11:22 UTC, Lari Taskula
Details | Diff | Splinter Review
Bug 14872: Reminder to update SMSnumber when primary phone is updated (4.87 KB, patch)
2015-09-24 11:24 UTC, Lari Taskula
Details | Diff | Splinter Review
Bug 14872: Reminder to update SMSnumber when primary phone is updated (5.09 KB, patch)
2016-02-03 22:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2015-09-22 14:11:31 UTC
It would be useful to remind patron to update his/her smsalertnumber after modifying primary phone number so that sms number also stays up to date.
Comment 1 Lari Taskula 2015-09-24 11:22:24 UTC Comment hidden (obsolete)
Comment 2 Lari Taskula 2015-09-24 11:24:12 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2016-02-03 22:01:51 UTC
Created attachment 47624 [details] [review]
Bug 14872: Reminder to update SMSnumber when primary phone is updated

Since SMS number (smsalertnumber) and primary phone are separated, it would
be useful to remind patron to update his/her SMS number when making changes
to primary phone. This can easily be forgotten, especially in OPAC where the
two fields are in different page (opac-memberentry.pl vs opac-messaging.pl).

This patch adds a reminder in the "hint"-div that activates whenever phone
field gets input (and phone-smsalertnumber do not match).

To test:
1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences
2. Navigate to OPAC -> your personal details
3. Input something to primary phone. You should not be notified at all
4. Navigate to Intra -> Patron -> Edit
5. Repeat step 3
6. Apply patch
7. Refresh Opac -> your personal details and Intra -> Patron -> Edit
8. Input something to primary phone and observe you will be notified to
   also update SMS number.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Fixed a small merge conflict in opac-memberentry.tt
Comment 4 Jonathan Druart 2016-02-09 11:21:12 UTC
I don't get the message at the OPAC.

The SMSSendDriver value should be checked using the TT plugin (Koha.Preference).
I don't know if we need a pref to control this behavior, maybe other libraries don't use the primary phone as the mobile phone.
Comment 5 Katrin Fischer 2016-02-09 11:52:49 UTC
(In reply to Jonathan Druart from comment #4)
> I don't get the message at the OPAC.
> 
> The SMSSendDriver value should be checked using the TT plugin
> (Koha.Preference).
> I don't know if we need a pref to control this behavior, maybe other
> libraries don't use the primary phone as the mobile phone.

I am a bit worried about that too. We offer, I think, 3 phone number fields, and some might have the habit/custom to put the landline in the first field and the mobile/work number in another, especially since one of the fields were once labelled differently.
Comment 6 Owen Leonard 2016-07-18 15:32:51 UTC
I wonder if a better long-term solution wouldn't be to have the SMS number field be an option to select one of the existing phone number fields: A dropdown menu where you choose to link SMS messages to primary phone, secondary phone, or other phone. It seems odd to me that we even have a separate field for SMS number.