Bugzilla – Attachment 45452 Details for
Bug 15324
Checkout page: Hide title "Waiting holds:" for patrons without waiting holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds
SIGNED-OFF-Bug-15324-Checkout-page-Hide-title-Wait.patch (text/plain), 1.68 KB, created by
Owen Leonard
on 2015-12-07 15:32:25 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2015-12-07 15:32:25 UTC
Size:
1.68 KB
patch
obsolete
>From 6d1e69780500dd678974894f8272eb2ac5cbad88 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Thu, 3 Dec 2015 22:53:24 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting > holds:" for patrons without waiting holds >Content-Type: text/plain; charset="utf-8" > >To reproduce: >- Make sure that you have a patron A with waiting holds and A patron B without waiting holds >- Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) >- At the right, there is a title "Waiting holds:" and a list of holds waiting >- Go to the checkout page for patron B >- At the right, you see a stray title "Waiting holds:" > >To test: >- Apply patch >- Repeat steps above >- Verify that the title "Waiting holds: does no longer display for patrons > without waiting holds. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > circ/circulation.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index f16475e..2f51625 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -457,9 +457,11 @@ if ($borrowernumber) { > # show all reserves of this borrower, and the position of the reservation .... > if ($borrowernumber) { > my $holds = Koha::Holds->search( { borrowernumber => $borrowernumber } ); >+ my $waitingHolds = $holds->waiting(); >+ $waitingHolds = undef if (! $waitingHolds->count() ); > $template->param( > holds_count => $holds->count(), >- WaitingHolds => scalar $holds->waiting(), >+ WaitingHolds => $waitingHolds, > ); > > $template->param( adultborrower => 1 ) if ( $borrower->{category_type} eq 'A' || $borrower->{category_type} eq 'I' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15324
:
45449
|
45452
|
45496
|
45500
|
45625
|
46062