The checkout page shows the H3 title "Waiting holds:" even if the patron does not have holds waiting. To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" Expected: The title is not displayes if patron has no holds waiting.
Created attachment 45449 [details] [review] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" To test: - Apply patch - Repeat steps above - Verify that the title "Waiting holds: does no longer display for patrons without waiting holds.
Created attachment 45452 [details] [review] [SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" To test: - Apply patch - Repeat steps above - Verify that the title "Waiting holds: does no longer display for patrons without waiting holds. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 45496 [details] [review] Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed
Marc, this is the way to go.
Introduced by bug 13851.
Created attachment 45500 [details] [review] Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed Sign-off on Jonathan's patch Signed-off-by: Marc Véron <veron@veron.ch> http://bugs.koha-community.org/show_bug.cgi?id=14324
Created attachment 45625 [details] [review] [PASSED QA] Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed Sign-off on Jonathan's patch Signed-off-by: Marc Véron <veron@veron.ch> http://bugs.koha-community.org/show_bug.cgi?id=14324 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46062 [details] [review] Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed Sign-off on Jonathan's patch Signed-off-by: Marc Véron <veron@veron.ch> http://bugs.koha-community.org/show_bug.cgi?id=14324 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master - Thanks!
Patch pushed to 3.22.x, will be in 3.22.2