Bug 15324 - Checkout page: Hide title "Waiting holds:" for patrons without waiting holds
Summary: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 13851
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-07 13:46 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds (1.58 KB, patch)
2015-12-07 15:12 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds (1.68 KB, patch)
2015-12-07 15:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15324: Do not display 'Waiting holds:" if no holds are waiting (2.10 KB, patch)
2015-12-08 15:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15324: Do not display 'Waiting holds:" if no holds are waiting (2.32 KB, patch)
2015-12-08 15:37 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 15324: Do not display 'Waiting holds:" if no holds are waiting (2.38 KB, patch)
2015-12-13 22:17 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15324: Do not display 'Waiting holds:" if no holds are waiting (2.44 KB, patch)
2015-12-30 03:42 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-07 13:46:31 UTC
The checkout page shows the H3 title "Waiting holds:" even if the patron does not have holds waiting.

To reproduce:
- Make sure that you have a patron A with waiting holds and A patron B without waiting holds
- Go to the checkout page for patron A (Home > Circulation > Checkouts > ...)
- At the right, there is a title "Waiting holds:" and a list of holds waiting
- Go to the checkout page for patron B
- At the right, you see a stray title "Waiting holds:"

Expected: The title is not displayes if patron has no holds waiting.
Comment 1 Marc Véron 2015-12-07 15:12:27 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2015-12-07 15:32:25 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-08 15:13:53 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-12-08 15:14:20 UTC
Marc, this is the way to go.
Comment 5 Jonathan Druart 2015-12-08 15:15:01 UTC
Introduced by bug 13851.
Comment 6 Marc Véron 2015-12-08 15:37:51 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2015-12-13 22:17:01 UTC Comment hidden (obsolete)
Comment 8 Brendan Gallagher 2015-12-30 03:42:22 UTC
Created attachment 46062 [details] [review]
Bug 15324: Do not display 'Waiting holds:" if no holds are waiting

Test plan:
- Make sure that you have a patron A with waiting holds and a patron B
  without waiting holds
- Go to the checkout page for patron A (Home > Circulation > Checkouts
> ...)
- At the right, there is a title "Waiting holds:" and a list of
  holds waiting
- Go to the checkout page for patron B
=> Without this patch "Waiting holds:" is displayed

Sign-off on Jonathan's patch
Signed-off-by: Marc Véron <veron@veron.ch>

http://bugs.koha-community.org/show_bug.cgi?id=14324

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 9 Brendan Gallagher 2015-12-30 03:42:35 UTC
Pushed to master - Thanks!
Comment 10 Julian Maurice 2015-12-31 09:08:03 UTC
Patch pushed to 3.22.x, will be in 3.22.2