Bugzilla – Attachment 47055 Details for
Bug 15607
Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15607: batch patron mod - do not update dates if not given
PASSED-QA-Bug-15607-batch-patron-mod---do-not-upda.patch (text/plain), 1.37 KB, created by
Katrin Fischer
on 2016-01-20 21:52:39 UTC
(
hide
)
Description:
[PASSED QA] Bug 15607: batch patron mod - do not update dates if not given
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-01-20 21:52:39 UTC
Size:
1.37 KB
patch
obsolete
>From d2e7bdfaf10e416f90e403def2597b3b53f5ac44 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Jan 2016 08:45:48 +0000 >Subject: [PATCH] [PASSED QA] Bug 15607: batch patron mod - do not update dates > if not given > >Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and >dateexpiry are not modified, they will be updated to today. >Indeed, dt_from_string returns today without parameters. > >Test plan: >- Set dateenrolled and expirydate for a patron >- Using the batch patron mod tool, update any field but dateenrolled and >expirydate. >=> Without this patch, the 2 date fields should be set to today >=> With this patch applied, the 2 date fields should not have been >modified. > >Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > tools/modborrowers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index f88581f..95d26de 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -266,7 +266,7 @@ if ( $op eq 'do' ) { > } > > for my $field ( qw( dateenrolled dateexpiry ) ) { >- $infos->{$field} = dt_from_string($infos->{$field}); >+ $infos->{$field} = dt_from_string($infos->{$field}) if $infos->{$field}; > } > > my @attributes = $input->param('patron_attributes'); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15607
:
46928
|
46930
|
46980
|
46983
| 47055