The 'batch parton modification' tool seems to overwrite 'dateenrolled' and 'expirydate' fields with $todaysdate, if any of these fields are left unpopulated when updating confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07 to test... 1/ Set 'dateenrolled' and/or 'expirydate' fields of a test user 2/ Use 'batch parton modification' tool to update any other field (eg: 'State') 3/ Confirm that user's 'dateenrolled' and/or 'expirydate' fields have been incorrectly updated to $todays date :(
Created attachment 46928 [details] updating 'state' field
Created attachment 46930 [details] 'dateenrolled' and 'expirydate' fields have now been modified
(In reply to Mason James from comment #0) > The 'batch parton modification' tool seems to overwrite 'dateenrolled' and > 'expirydate' fields with $todaysdate, if any of these fields are left > unpopulated when updating > > confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07 ..this bug will also exist in 3.22.2 and 3.20.8 releases
Created attachment 46980 [details] [review] Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified.
Created attachment 46983 [details] [review] [SIGNED-OFF] Bug 15607: batch patron mod - do not update dates if not given batch works as described before applying this batch if you make (Batch patrons modification) all the Registration date and Expiry date fields for the affected patrons will be with today date and the original data will be lost . After applying this batch everything work fine . Thank you Jonathan
CCing Rmaint 3.22 and 3.20: this fix must be in the 3.22.2 and 3.20.8
Created attachment 47055 [details] [review] [PASSED QA] Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
PUshed to master, thanks for your work!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.