Bugzilla – Attachment 48843 Details for
Bug 15982
Serials numbering patterns can be deleted without warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15982 - Serials numbering patterns can be deleted without warning
Bug-15982---Serials-numbering-patterns-can-be-dele.patch (text/plain), 2.44 KB, created by
Jonathan Druart
on 2016-03-09 11:05:54 UTC
(
hide
)
Description:
Bug 15982 - Serials numbering patterns can be deleted without warning
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-09 11:05:54 UTC
Size:
2.44 KB
patch
obsolete
>From 01cac4d7c88c325f5309f8709fee4799ef1d3f46 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 4 Mar 2016 12:07:44 -0500 >Subject: [PATCH] Bug 15982 - Serials numbering patterns can be deleted without > warning > >A JavaScript alert should ask the user to confirm deletion of a serial >numbering pattern. This patch adds this to the template. > >To test, apply the patch and go to Serials -> Manage numbering patterns. > >- In the list of patterns, click any "Delete" link. >- Verify that a JavaScript alert is triggered. >- Test that cancelling the alert cancels the deletion operation. >- Test that confirming the alert allows the deletion to complete. > >Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/serials/subscription-numberpatterns.tt | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >index e0c56fe..07c1f0d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >@@ -4,6 +4,11 @@ > [% INCLUDE 'calendar.inc' %] > <script type="text/javascript"> > //<![CDATA[ >+ >+function confirmDelete() { >+ return confirm(_("Are you sure you want to delete this numbering pattern?")); >+} >+ > [% IF (new or modify) %] > function testPattern() { > var frequencyid = $("#frequency").val(); >@@ -57,6 +62,11 @@ > function show_blocking_subs() { > $("#blocking_subs").show(); > } >+$(document).ready(function(){ >+ $(".delete_pattern").on("click",function(){ >+ return confirmDelete(); >+ }); >+}); > //]]> > </script> > </head> >@@ -318,7 +328,7 @@ function show_blocking_subs() { > <td>[% numberpattern.displayorder %]</td> > <td> > <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=modify&id=[% numberpattern.id %]">Edit</a> | >- <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=del&id=[% numberpattern.id %]">Delete</a> >+ <a class="delete_pattern" href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=del&id=[% numberpattern.id %]">Delete</a> > </td> > </tr> > [% END %] >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15982
:
48701
|
48818
| 48843