Bug 15982 - Serials numbering patterns can be deleted without warning
Summary: Serials numbering patterns can be deleted without warning
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/serials/subscription-nu...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-04 17:00 UTC by Owen Leonard
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15982 - Serials numbering patterns can be deleted without warning (2.35 KB, patch)
2016-03-04 17:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15982 - Serials numbering patterns can be deleted without warning (2.37 KB, patch)
2016-03-08 20:37 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15982 - Serials numbering patterns can be deleted without warning (2.44 KB, patch)
2016-03-09 11:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-04 17:00:45 UTC
When the user tries to delete a serials numbering pattern there should be a JavaScript alert asking for confirmation.
Comment 1 Owen Leonard 2016-03-04 17:09:34 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-08 20:37:34 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-09 11:05:54 UTC
Created attachment 48843 [details] [review]
Bug 15982 - Serials numbering patterns can be deleted without warning

A JavaScript alert should ask the user to confirm deletion of a serial
numbering pattern. This patch adds this to the template.

To test, apply the patch and go to Serials -> Manage numbering patterns.

- In the list of patterns, click any "Delete" link.
- Verify that a JavaScript alert is triggered.
- Test that cancelling the alert cancels the deletion operation.
- Test that confirming the alert allows the deletion to complete.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-09 16:27:08 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-14 09:27:27 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 09:04:42 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.