Bugzilla – Attachment 50453 Details for
Bug 16300
Remove the use of "onclick" from circulation and fine rules template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template
Bug-16300---Remove-the-use-of-onclick-from-circula.patch (text/plain), 2.11 KB, created by
Marc Véron
on 2016-04-20 09:21:25 UTC
(
hide
)
Description:
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-20 09:21:25 UTC
Size:
2.11 KB
patch
obsolete
>From 23bb83aaf63346d5a21e40b2a6eca003ed26aff4 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 19 Apr 2016 14:25:02 -0400 >Subject: [PATCH] Bug 16300 - Remove the use of "onclick" from circulation and > fine rules template >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch updates the circulation and fine rules template so that the >"clear" button does not require an "onclick" attribute. > >To test, apply the patch and go to Administration -> Circulation and >fine rules. > >- Edit an existing rule. >- Click the "Clear" button and confirm. The entry form should be reset > to its blank state. >- Click the "Clear" button and cancel. The entry form should remain the > same. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index c7e27ad..6c7e522 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -94,6 +94,10 @@ $(document).ready(function() { > $("#default-circulation-rules tr:last td:eq(1) select").attr('disabled', 'disabled'); > return false; > }); >+ $("#clear_edit").on("click",function(e){ >+ e.preventDefault(); >+ clear_edit(); >+ }); > }); > //]]> > </script> >@@ -332,7 +336,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > <td colspan="2"> > <input type="hidden" name="branch" value="[% current_branch %]"/> > <input type="submit" value="Save" class="submit" /> >- <input type="button" name="cancel" value="Clear" onclick="clear_edit();return false;" /> >+ <input type="button" name="cancel" value="Clear" id="clear_edit" /> > </td> > </tr> > <tfoot> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16300
:
50435
| 50453