Bug 16300 - Remove the use of "onclick" from circulation and fine rules template
Summary: Remove the use of "onclick" from circulation and fine rules template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/smart-rules.pl
Keywords:
Depends on: 15456
Blocks: 17858
  Show dependency treegraph
 
Reported: 2016-04-19 18:23 UTC by Owen Leonard
Modified: 2020-01-06 20:14 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template (2.01 KB, patch)
2016-04-19 18:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template (2.11 KB, patch)
2016-04-20 09:21 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-19 18:23:40 UTC
There is one place where an "onclick" attribute is used in admin/smart-rules.tt. It should be rewritten so that JS functionality is separate from the markup.
Comment 1 Owen Leonard 2016-04-19 18:28:18 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-20 09:21:25 UTC
Created attachment 50453 [details] [review]
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template

This patch updates the circulation and fine rules template so that the
"clear" button does not require an "onclick" attribute.

To test, apply the patch and go to Administration -> Circulation and
fine rules.

- Edit an existing rule.
- Click the "Clear" button and confirm. The entry form should be reset
  to its blank state.
- Click the "Clear" button and cancel. The entry form should remain the
  same.

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Katrin Fischer 2018-03-31 07:24:52 UTC
Hi Owen, looking at this, maybe it would make sense to redo the patch without the dependency on 15456. What do you think? Moving to PDA for now.
Comment 4 Hayley Pelham 2019-05-02 03:51:35 UTC
This look to have been remedied on master. Setting to Resolved.