Bugzilla – Attachment 51075 Details for
Bug 16404
Fix Circulation/Branch.t (tests 8-11)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16404: Fix Circulation/Branch.t (tests 8-11)
Bug-16404-Fix-CirculationBrancht-tests-8-11.patch (text/plain), 3.22 KB, created by
Jonathan Druart
on 2016-05-02 09:36:07 UTC
(
hide
)
Description:
Bug 16404: Fix Circulation/Branch.t (tests 8-11)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-05-02 09:36:07 UTC
Size:
3.22 KB
patch
obsolete
>From 8d428f9ec3cebc9d88b8e8382737a59ef6047f40 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Sat, 30 Apr 2016 14:52:29 +0200 >Subject: [PATCH] Bug 16404: Fix Circulation/Branch.t (tests 8-11) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Resolves: >Failed test 'GetBranchitem returns holdallowed and return branch' >at t/db_dependent/Circulation/Branch.t line 226. > Structures begin differing at: > $got->{hold_fulfillment_policy} = 'any' > $expected->{hold_fulfillment_policy} = Does not exist >Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' >at t/db_dependent/Circulation/Branch.t line 234. > Structures begin differing at: > $got->{hold_fulfillment_policy} = 'any' > $expected->{hold_fulfillment_policy} = Does not exist >Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' >at t/db_dependent/Circulation/Branch.t line 239. > Structures begin differing at: > $got->{hold_fulfillment_policy} = 'any' > $expected->{hold_fulfillment_policy} = Does not exist >Failed test 'With only one parametern GetBranchItemRule returns default values' >at t/db_dependent/Circulation/Branch.t line 244. > Structures begin differing at: > $got->{hold_fulfillment_policy} = 'any' > $expected->{hold_fulfillment_policy} = Does not exist > >Test plan: >Run test before and after applying this patch. > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Note: I do not see the usefulness of the lazy_any variable, I don't >think it make things easier to read. >--- > t/db_dependent/Circulation/Branch.t | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Circulation/Branch.t b/t/db_dependent/Circulation/Branch.t >index d2f4583..c0c89c6 100644 >--- a/t/db_dependent/Circulation/Branch.t >+++ b/t/db_dependent/Circulation/Branch.t >@@ -223,27 +223,28 @@ is_deeply( > ); > > #Test GetBranchItemRule >+my @lazy_any = ( 'hold_fulfillment_policy' => 'any' ); > is_deeply( > GetBranchItemRule( > $samplebranch1->{branchcode}, >- $sampleitemtype1->{itemtype} >+ $sampleitemtype1->{itemtype}, > ), >- { returnbranch => 'homebranch', holdallowed => 5 }, >+ { returnbranch => 'homebranch', holdallowed => 5, @lazy_any }, > "GetBranchitem returns holdallowed and return branch" > ); > is_deeply( > GetBranchItemRule(), >- { returnbranch => 'homebranch', holdallowed => 3 }, >+ { returnbranch => 'homebranch', holdallowed => 3, @lazy_any }, > "Without parameters GetBranchItemRule returns the values in default_circ_rules" > ); > is_deeply( > GetBranchItemRule( $samplebranch2->{branchcode} ), >- { returnbranch => 'holdingbranch', holdallowed => 1 }, >+ { returnbranch => 'holdingbranch', holdallowed => 1, @lazy_any }, > "With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules" > ); > is_deeply( > GetBranchItemRule( -1, -1 ), >- { returnbranch => 'homebranch', holdallowed => 3 }, >+ { returnbranch => 'homebranch', holdallowed => 3, @lazy_any }, > "With only one parametern GetBranchItemRule returns default values" > ); > >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16404
:
51051
|
51052
| 51075