Resolve: # Failed test 'GetBranchitem returns holdallowed and return branch' # at t/db_dependent/Circulation/Branch.t line 226. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' # at t/db_dependent/Circulation/Branch.t line 234. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' # at t/db_dependent/Circulation/Branch.t line 239. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'With only one parametern GetBranchItemRule returns default values' # at t/db_dependent/Circulation/Branch.t line 244. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist t/db_dependent/Circulation/Branch.t .. 13/14 # Looks like you failed 4 tests of 14. t/db_dependent/Circulation/Branch.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Created attachment 51051 [details] [review] Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch.
Created attachment 51052 [details] [review] Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 51075 [details] [review] Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: I do not see the usefulness of the lazy_any variable, I don't think it make things easier to read.
Pushed to master for Koha 16.05! Thanks Marcel!
Not needed in stable versions, status changed to RESOLVED