Bug 16404 - Fix Circulation/Branch.t (tests 8-11)
Summary: Fix Circulation/Branch.t (tests 8-11)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Galen Charlton
URL:
Keywords:
Depends on: 15534
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-30 12:55 UTC by Marcel de Rooy
Modified: 2016-12-05 21:22 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16404: Fix Circulation/Branch.t (tests 8-11) (2.96 KB, patch)
2016-04-30 12:58 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16404: Fix Circulation/Branch.t (tests 8-11) (3.05 KB, patch)
2016-04-30 13:01 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16404: Fix Circulation/Branch.t (tests 8-11) (3.22 KB, patch)
2016-05-02 09:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-04-30 12:55:49 UTC
Resolve:
#   Failed test 'GetBranchitem returns holdallowed and return branch'
#   at t/db_dependent/Circulation/Branch.t line 226.
#     Structures begin differing at:
#          $got->{hold_fulfillment_policy} = 'any'
#     $expected->{hold_fulfillment_policy} = Does not exist

#   Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules'
#   at t/db_dependent/Circulation/Branch.t line 234.
#     Structures begin differing at:
#          $got->{hold_fulfillment_policy} = 'any'
#     $expected->{hold_fulfillment_policy} = Does not exist

#   Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules'
#   at t/db_dependent/Circulation/Branch.t line 239.
#     Structures begin differing at:
#          $got->{hold_fulfillment_policy} = 'any'
#     $expected->{hold_fulfillment_policy} = Does not exist

#   Failed test 'With only one parametern GetBranchItemRule returns default values'
#   at t/db_dependent/Circulation/Branch.t line 244.
#     Structures begin differing at:
#          $got->{hold_fulfillment_policy} = 'any'
#     $expected->{hold_fulfillment_policy} = Does not exist
t/db_dependent/Circulation/Branch.t .. 13/14 # Looks like you failed 4 tests of 14.
t/db_dependent/Circulation/Branch.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Comment 1 Marcel de Rooy 2016-04-30 12:58:03 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-30 13:01:24 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-05-02 09:36:07 UTC
Created attachment 51075 [details] [review]
Bug 16404: Fix Circulation/Branch.t (tests 8-11)

Resolves:
Failed test 'GetBranchitem returns holdallowed and return branch'
at t/db_dependent/Circulation/Branch.t line 226.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules'
at t/db_dependent/Circulation/Branch.t line 234.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules'
at t/db_dependent/Circulation/Branch.t line 239.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'With only one parametern GetBranchItemRule returns default values'
at t/db_dependent/Circulation/Branch.t line 244.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist

Test plan:
Run test before and after applying this patch.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note: I do not see the usefulness of the lazy_any variable, I don't
think it make things easier to read.
Comment 4 Kyle M Hall 2016-05-03 15:22:23 UTC
Pushed to master for Koha 16.05! Thanks Marcel!
Comment 5 Julian Maurice 2016-05-16 08:59:02 UTC
Not needed in stable versions, status changed to RESOLVED