Bugzilla – Attachment 52469 Details for
Bug 16742
Remove unused template subject.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 16742: Remove unused template subject.tt
SIGNED-OFFBug-16742-Remove-unused-template-subject.patch (text/plain), 3.59 KB, created by
Héctor Eduardo Castro Avalos
on 2016-06-16 15:44:18 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 16742: Remove unused template subject.tt
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-06-16 15:44:18 UTC
Size:
3.59 KB
patch
obsolete
>From bfebe1d394ba397a1c65604ca4f089a261e2c500 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Wed, 15 Jun 2016 14:28:31 +0200 >Subject: [PATCH] [SIGNED-OFF]Bug 16742: Remove unused template subject.tt > >The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >is not used and can be removed. > >To test: >- Apply patch >- Verify that catalogue/moredetail.pl works as before (go to a > biblio with items and click 'Items' in left hand menu) > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >--- > catalogue/moredetail.pl | 8 +--- > .../prog/en/modules/catalogue/subject.tt | 46 -------------------- > 2 files changed, 1 insertion(+), 53 deletions(-) > delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index f94c1ff..b0ed654 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -30,7 +30,6 @@ use C4::Acquisition; > use C4::Output; > use C4::Auth; > use C4::Serials; >-use C4::Circulation; # to use itemissues > use C4::Members; # to use GetMember > use C4::Search; # enabled_staff_search_views > use C4::Members qw/GetHideLostItemsPreference/; >@@ -42,15 +41,10 @@ use Koha::Items; > > my $query=new CGI; > >-# FIXME subject is not exported to the template? >-my $subject=$query->param('subject'); >- > # if its a subject we need to use the subject.tt > my ($template, $loggedinuser, $cookie) = get_template_and_user( > { >- template_name => ( $subject >- ? 'catalogue/subject.tt' >- : 'catalogue/moredetail.tt'), >+ template_name => 'catalogue/moredetail.tt', > query => $query, > type => "intranet", > authnotrequired => 0, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >deleted file mode 100644 >index 3bf55a9..0000000 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >+++ /dev/null >@@ -1,46 +0,0 @@ >-[% INCLUDE 'doc-head-open.inc' %] >-<title>Koha › Catalog › Subject search results</title> >-[% INCLUDE 'doc-head-close.inc' %] >-</head> >-<body id="catalog_subject" class="catalog"> >- >-[% INCLUDE 'header.inc' %] >-[% INCLUDE 'cat-search.inc' %] >- >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/catalogue/search.pl">Catalog</a> › Subject search results</div> >- >-<div id="doc3" class="yui-t2"> >- >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >- >-<div id="catalogue_detail_biblio"> >- >-<h1>Subject search results</h1> >- >-<div id="resultnumber"><p>Results <b>[% startfrom %]</b> through <b>[% endat %] of [% numrecords %]</b> records.<br /></p></div> >- >-<table> >-<tr> >- <th>Subject headings</th> >- </tr> >-[% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >- <tr> >- <td> >- <a href="/cgi-bin/koha/search.pl?type=[% IF ( SEARCH_RESULT.opac ) %]opac[% ELSE %]intra[% END %]&subjectitems=[% SEARCH_RESULT.subject2 |html %]">[% SEARCH_RESULT.subject %]</a> >- </td> >- </tr> >-[% END %] >-</table> >-<p><a class="button" href="search.pl?[% FOREACH FORMINPUT IN FORMINPUTS %][% FORMINPUT.line |url %]&[% END %]startfrom=[% prevstartfrom %]">Previous records</a> <a class="button" href="search.pl?[% FOREACH FORMINPUT IN FORMINPUTS %][% FORMINPUT.line %]&[% END %]startfrom=[% nextstartfrom %]">Next records</a></p> >- >-</div> >- >-</div> >-</div> >-<div class="yui-b"> >-[% INCLUDE 'cat-menu.inc' %] >-</div> >-</div> >-[% INCLUDE 'intranet-bottom.inc' %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16742
:
52424
|
52469
|
52471
|
52517
|
52518