It seems that catalogue/subject.tt is never used. There is a call in catalogue/moredetail.pl line 52 depending on a param 'subject', but catalogue/moredetail.pl is never called with such param. See also FIXME comment on line 45 and comment 2 in Bug 15927: Catalog -> subject.tt (is this template used?
(In reply to Marc Véron from comment #0) > It seems that catalogue/subject.tt is never used. As far as I know it hasn't been used since version 1.x.
Created attachment 52424 [details] [review] Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pm works as before (go to a biblio with items and click 'Items' in left hand menue)
Created attachment 52469 [details] [review] [SIGNED-OFF]Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 52471 [details] [review] Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt"
Created attachment 52517 [details] [review] Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 52518 [details] [review] Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hard to say if it's not used by anyone, but it is out-of-sync with other templates and need work anyway.
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10