Bugzilla – Attachment 52846 Details for
Bug 16805
Log in with database admin user breaks OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16805: Tweak new test message to say getalert
Bug-16805-Tweak-new-test-message-to-say-getalert.patch (text/plain), 1.46 KB, created by
Mark Tompsett
on 2016-06-24 17:02:31 UTC
(
hide
)
Description:
Bug 16805: Tweak new test message to say getalert
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-06-24 17:02:31 UTC
Size:
1.46 KB
patch
obsolete
>From c532a3c33a38357062e50f0014bd05885d8ba5fb Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 24 Jun 2016 12:28:27 -0400 >Subject: [PATCH] Bug 16805: Tweak new test message to say getalert > >It said 'addalert', which is likely a cut-paste typo. >Plus, let's keep running the other tests if that one >goes bad. > >TEST PLAN >--------- >1) Apply Jonathan's test patch >2) prove t/db_dependent/Letters.t > -- dies before finishing tests >3) Apply this test patch >4) prove t/db_dependent/Letters.t > -- says 'getalert' > -- fails on one test, but keeps going. >5) run koha qa test tools. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > t/db_dependent/Letters.t | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index a4ddd2a..c043db1 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -212,8 +212,11 @@ isnt( $alert_id, undef, 'addalert does not return undef' ); > > > # getalert >-my $alerts = C4::Letters::getalert(); >-is( @$alerts, 1, 'addalert should not fail without parameter' ); >+my $alerts; >+eval { >+ $alerts = C4::Letters::getalert(); >+ is( @$alerts, 1, 'getalert should not fail without parameter' ); >+} || fail('getalert failed horribly without a parameter'); > $alerts = C4::Letters::getalert($borrowernumber); > is( @$alerts, 1, 'addalert adds an alert' ); > is( $alerts->[0]->{alertid}, $alert_id, 'addalert returns the alert id correctly' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16805
:
52762
|
52764
|
52827
|
52845
|
52846
|
52847
|
52877
|
52878
|
52879
|
52880
|
52881
|
52882