Bugzilla – Attachment 56923 Details for
Bug 17514
Record details page uses incorrect class "results_summary"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17514 - Record details page uses incorrect class "results_summary"
Bug-17514---Record-details-page-uses-incorrect-cla.patch (text/plain), 4.64 KB, created by
Kyle M Hall
on 2016-10-27 14:34:16 UTC
(
hide
)
Description:
Bug 17514 - Record details page uses incorrect class "results_summary"
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2016-10-27 14:34:16 UTC
Size:
4.64 KB
patch
obsolete
>From 143705e54a861356fbca9ee364df087b0f3b27fd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 27 Oct 2016 14:32:59 +0000 >Subject: [PATCH] Bug 17514 - Record details page uses incorrect class > "results_summary" > >The record details page re-uses the class results_summary which is >semantically incorrect and causes unwanted interactions with the styling >of the actual results page which also uses the results_summary class. We >should change the instances of the results_summary class to >details_summary on this page. > >Test Plan: >1) Apply this patch >2) Browse to the record details for a bib >3) View the html, note that no elements have the class results_summary, > instead, you should see the class details_summary >--- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 2b6583b..2aa5f14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -388,7 +388,7 @@ function verify_images() { > [% XSLTBloc %] > > [% IF shelves.count %] >- <span class="results_summary"><span class="label">Lists that include this title: </span> >+ <span class="details_summary"><span class="label">Lists that include this title: </span> > [% FOREACH s IN shelves %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% s.shelfnumber %]">[% s.shelfname %]</a> > [% IF ( loop.last ) %][% ELSE %]|[% END %] >@@ -396,7 +396,7 @@ function verify_images() { > </span> > [% END %] > [% IF ( TagsEnabled && TagsShowOnDetail && TagLoop ) %] >- <span class="results_summary"><span class="label">Tags:</span> >+ <span class="details_summary"><span class="label">Tags:</span> > [% FOREACH TagLoo IN TagLoop %] > [% IF ( CAN_user_tools_moderate_tags ) %] > <a href="/cgi-bin/koha/tags/list.pl?tag=[% TagLoo.term |url %]">[% TagLoo.term |html %]</a> >@@ -407,10 +407,10 @@ function verify_images() { > [% END %] > </span> > [% END %] >- <span id="catalogue_detail_marc_preview" class="results_summary"><span class="label">MARC Preview:</span> <a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% biblionumber %]&viewas=html" title="MARC" class="previewMARC">Show</a></span> >+ <span id="catalogue_detail_marc_preview" class="details_summary"><span class="label">MARC Preview:</span> <a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% biblionumber %]&viewas=html" title="MARC" class="previewMARC">Show</a></span> > > [% IF ( holdcount ) %] >- <span class="results_summary"> >+ <span class="details_summary"> > <span class="label">Holds:</span> > <span class="number_box"> > <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">[% holdcount %]</a> >@@ -419,7 +419,7 @@ function verify_images() { > [% END %] > > [% IF ( article_requests_count = Biblio.ArticleRequestsActiveCount( biblionumber ) ) %] >- <span class="results_summary"> >+ <span class="details_summary"> > <span class="label">Article requests:</span> > <span class="number_box"> > <a href="/cgi-bin/koha/circ/request-article.pl?biblionumber=[% biblionumber %]">[% article_requests_count %]</a> >@@ -851,7 +851,7 @@ function verify_images() { > <div id="holdings"> > > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectProfile') && Koha.Preference('NovelistSelectStaffView') == 'above' ) %] >- <span class="results_summary NovelistSelect" style="display:none;"> >+ <span class="details_summary NovelistSelect" style="display:none;"> > <span class="label">Novelist Select: </span> > <div data-novelist-novelistselect=[% normalized_isbn %]></div> > </span> >@@ -883,7 +883,7 @@ function verify_images() { > [% END %] > > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectProfile') && Koha.Preference('NovelistSelectStaffView') == 'below' ) %] >- <span class="results_summary NovelistSelect" style="display:none;"> >+ <span class="details_summary NovelistSelect" style="display:none;"> > <span class="label">Novelist Select: </span> > <div data-novelist-novelistselect=[% normalized_isbn %]></div> > </span> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17514
: 56923