Bug 17514 - Record details page uses incorrect class "results_summary"
Summary: Record details page uses incorrect class "results_summary"
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-27 14:32 UTC by Kyle M Hall
Modified: 2023-06-25 14:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17514 - Record details page uses incorrect class "results_summary" (4.64 KB, patch)
2016-10-27 14:34 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2016-10-27 14:32:32 UTC
The record details page re-uses the class results_summary which is semantically incorrect and causes unwanted interactions with the styling of the actual results page which also uses the results_summary class. We should change the instances of the results_summary class to details_summary on this page.
Comment 1 Kyle M Hall 2016-10-27 14:34:16 UTC
Created attachment 56923 [details] [review]
Bug 17514 - Record details page uses incorrect class "results_summary"

The record details page re-uses the class results_summary which is
semantically incorrect and causes unwanted interactions with the styling
of the actual results page which also uses the results_summary class. We
should change the instances of the results_summary class to
details_summary on this page.

Test Plan:
1) Apply this patch
2) Browse to the record details for a bib
3) View the html, note that no elements have the class results_summary,
   instead, you should see the class details_summary
Comment 2 Owen Leonard 2016-10-27 14:54:06 UTC
I agree about the semantic issue, but is the practical aspect of this that it creates problems with customizations?

If we have a patch adding details_summary, staff-global.css should be modified to add style for it so that it doesn't break the existing view. As it is, tags, MARC preview, and Holds all display on the same line.

This patch must also modify the XSL stylesheet since many of the "results_summary" instances come from there.
Comment 3 Owen Leonard 2016-10-27 14:56:31 UTC
Also: This patch modifies the staff client template, but the same issue exists in the OPAC.
Comment 4 Katrin Fischer 2016-10-27 16:34:38 UTC
I agree with Owen - we are using results_summary in combination with the unique id from the body which avoids any problems. But we'd probably have to change the CSS for quite a few libraries if these classes were changed suddenly.
Comment 5 Katrin Fischer 2020-01-11 15:59:05 UTC
Kyle, would you agree to make this WONTFIX? (see last comments)
Comment 6 Katrin Fischer 2023-06-25 14:32:55 UTC
(In reply to Katrin Fischer from comment #5)
> Kyle, would you agree to make this WONTFIX? (see last comments)

Interpreting 2.5 years of silence as yes :)