Bugzilla – Attachment 60351 Details for
Bug 18036
Improve test coverage for themelanguage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18036: Perlcritic improve t/db_dependent/Templates.t
Bug-18036-Perlcritic-improve-tdbdependentTemplates.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2017-02-16 14:12:22 UTC
(
hide
)
Description:
Bug 18036: Perlcritic improve t/db_dependent/Templates.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-02-16 14:12:22 UTC
Size:
1.64 KB
patch
obsolete
>From a080f0e6d74ab11ab7c41513250e320ba5cc344a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 2 Feb 2017 12:16:01 -0500 >Subject: [PATCH] Bug 18036: Perlcritic improve t/db_dependent/Templates.t > >TEST PLAN >--------- >1) apply 17982 >2) perlcritic -3 t/db_dependent/Templates.t > -- messages >3) apply this patch >4) perlcritic -3 t/db_dependent/Templates.t > -- OK >5) run koha qa test tools > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Templates.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Templates.t b/t/db_dependent/Templates.t >index 5c3b7c8..24bfd5d 100755 >--- a/t/db_dependent/Templates.t >+++ b/t/db_dependent/Templates.t >@@ -43,10 +43,10 @@ my $columns = C4::Templates::GetColumnDefs( $query ); > > is( ref( $columns ) eq 'HASH', 1, 'GetColumnDefs returns a hashref' ); > # get the tables names, sorted >-my @keys = sort keys %$columns; >-is( scalar @keys, 6, "GetColumnDefs correctly returns the 5 tables defined in columns.def" ); >-my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics', 'subscription'); >-cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables"); >+my @keys = sort keys %{$columns}; >+is( scalar @keys, 6, 'GetColumnDefs correctly returns the 5 tables defined in columns.def' ); >+my @tables = qw( biblio biblioitems borrowers items statistics subscription ); >+cmp_deeply( \@keys, \@tables, 'GetColumnDefs returns the expected tables'); > > subtest 'Testing themelanguage for unique themes (BZ 17982)' => sub { > plan tests => 1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18036
:
59767
|
59818
|
59819
|
59820
|
59821
|
59822
|
59823
|
59824
|
59825
|
59838
|
59839
|
59843
|
59844
|
59845
| 60351 |
60352
|
60353