Bugzilla – Attachment 65213 Details for
Bug 17829
Move GetMember to Koha::Patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17829: Fix import patron
Bug-17829-Fix-import-patron.patch (text/plain), 1.95 KB, created by
Jonathan Druart
on 2017-07-25 13:32:44 UTC
(
hide
)
Description:
Bug 17829: Fix import patron
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-07-25 13:32:44 UTC
Size:
1.95 KB
patch
obsolete
>From 35863f8c8215cc6277f4d929395e4a9257b7f956 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 25 Jul 2017 10:29:06 -0300 >Subject: [PATCH] Bug 17829: Fix import patron > >Can't call method "unblessed" on an undefined value at >/home/vagrant/kohaclone/tools/import_borrowers.pl line 230, <$fh> line 2. >--- > tools/import_borrowers.pl | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >diff --git a/tools/import_borrowers.pl b/tools/import_borrowers.pl >index 76dc2995bd..66190e2737 100755 >--- a/tools/import_borrowers.pl >+++ b/tools/import_borrowers.pl >@@ -227,15 +227,9 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) { > my $borrowernumber; > my $member; > if ( ($matchpoint eq 'cardnumber') && ($borrower{'cardnumber'}) ) { >- $member = Koha::Patrons->find( { cardnumber => $borrower{'cardnumber'} } )->unblessed; >- if ($member) { >- $borrowernumber = $member->{'borrowernumber'}; >- } >+ $member = Koha::Patrons->find( { cardnumber => $borrower{'cardnumber'} } ); > } elsif ( ($matchpoint eq 'userid') && ($borrower{'userid'}) ) { > $member = Koha::Patrons->find( { userid => $borrower{'userid'} } )->unblessed; >- if ($member) { >- $borrowernumber = $member->{'borrowernumber'}; >- } > } elsif ($extended) { > if (defined($matchpoint_attr_type)) { > foreach my $attr (@$patron_attributes) { >@@ -248,6 +242,13 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) { > } > } > >+ if ($member) { >+ $member = $member->unblessed; >+ $borrowernumber = $member->{'borrowernumber'}; >+ } else { >+ $member = {}; >+ } >+ > if ( C4::Members::checkcardnumber( $borrower{cardnumber}, $borrowernumber ) ) { > push @errors, { > invalid_cardnumber => 1, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17829
:
64872
|
64873
|
64971
|
64972
|
64973
|
64976
|
65002
| 65213 |
65286
|
65549
|
65778
|
66360
|
68634