Bug 17829 - Move GetMember to Koha::Patron
Summary: Move GetMember to Koha::Patron
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi
URL:
Whiteboard:
Keywords:
Depends on: 17554 17680 17738 17737
Blocks: 16846 18403
  Show dependency treegraph
 
Reported: 2016-12-29 16:20 UTC by Jonathan Druart
Modified: 2017-06-23 18:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-12-29 16:20:31 UTC

    
Comment 1 Jonathan Druart 2016-12-29 16:24:25 UTC
See https://github.com/joubu/Koha/commits/bug_17829
Comment 2 Jonathan Druart 2017-02-24 09:52:34 UTC
Remote branch has been rebased against master.
Comment 3 Jonathan Druart 2017-03-22 13:55:07 UTC
Remote branch has been rebased against master.

Asking for a signoff now.

Test plan:
- send notices
- place holds
- play with acquisition: create basket, orders, receive them, transfer them
- play with circulation: checkout/in
- play with patrons: add a discharge, delete a patron, edit password and permissions, create invoices and pay them
Comment 4 Jonathan Druart 2017-03-31 19:20:33 UTC
Remote branch has been rebased against master.
Comment 5 Jonathan Druart 2017-04-11 20:13:14 UTC
I have worked for several days on bug 18403, on top of these patches, and did not find any errors.
I am quite confident with these patches, even if the changes are important. Please do not let them wait too long.
Comment 6 Martin Renvoize 2017-04-28 15:40:37 UTC
Not sure how signoff works on a github branch.. but I've tested thoroughly and am happy to signoff.
Comment 7 Jonathan Druart 2017-06-02 15:51:26 UTC
Remote branch has been rebased.
Comment 8 Tomás Cohen Arazi 2017-06-23 18:45:42 UTC
(In reply to Jonathan Druart from comment #7)
> Remote branch has been rebased.

It doesn't apply due to updatedatabase.pl conflicts...