Bugzilla – Attachment 69120 Details for
Bug 18712
make test is failing with an empty DB - t/Matcher.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18712: Remove unecessary fixtures
Bug-18712-Remove-unecessary-fixtures.patch (text/plain), 1.86 KB, created by
Nick Clemens
on 2017-11-13 13:37:54 UTC
(
hide
)
Description:
Bug 18712: Remove unecessary fixtures
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2017-11-13 13:37:54 UTC
Size:
1.86 KB
patch
obsolete
>From 84f7dbb8e98e37aa5e91136e261f70a4f979cd40 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 2 Nov 2017 10:26:08 -0300 >Subject: [PATCH] Bug 18712: Remove unecessary fixtures > >2 fixtures are in a subroutine that is never called, it can be removed > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/Biblio.t | 23 ----------------------- > t/Calendar.t | 10 ---------- > 2 files changed, 33 deletions(-) > >diff --git a/t/Biblio.t b/t/Biblio.t >index 4ade7cc..446afe2 100755 >--- a/t/Biblio.t >+++ b/t/Biblio.t >@@ -21,31 +21,8 @@ use Test::More; > use Test::MockModule; > use Test::Warn; > >-use Module::Load::Conditional qw/check_install/; >- >-BEGIN { >- if ( check_install( module => 'Test::DBIx::Class' ) ) { >- plan tests => 47; >- } else { >- plan skip_all => "Need Test::DBIx::Class" >- } >-} >- > use_ok('C4::Biblio'); > >-#use Test::DBIx::Class {}, 'Biblio'; >-use Test::DBIx::Class; #No difference between these two invocations in time taken to execute tests. >- >-sub fixtures { >- my ( $data ) = @_; >- fixtures_ok [ >- Biblio => [ >- [ qw/ biblionumber datecreated timestamp / ], >- @$data, >- ], >- ], 'add fixtures'; >-} >- > my $db = Test::MockModule->new('Koha::Database'); > $db->mock( _new_schema => sub { return Schema(); } ); > >diff --git a/t/Calendar.t b/t/Calendar.t >index e0128b7..1c3f194 100755 >--- a/t/Calendar.t >+++ b/t/Calendar.t >@@ -39,16 +39,6 @@ use_ok('Koha::Calendar'); > > use Test::DBIx::Class; > >-sub fixtures { >- my ( $data ) = @_; >- fixtures_ok [ >- Biblio => [ >- [ qw/ biblionumber datecreated timestamp / ], >- @$data, >- ], >- ], 'add fixtures'; >-} >- > my $db = Test::MockModule->new('Koha::Database'); > $db->mock( > _new_schema => sub { return Schema(); } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18712
:
63893
|
68890
|
68891
|
68985
|
68986
|
68987
|
69119
| 69120 |
69121