Bugzilla – Attachment 71362 Details for
Bug 15752
Automatically switch from circulation to new patron when a cardnumber is scanned during circulation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15752: (QA follow-up) Remove unecessary redirect
Bug-15752-QA-follow-up-Remove-unecessary-redirect.patch (text/plain), 1.97 KB, created by
Katrin Fischer
on 2018-02-09 07:14:22 UTC
(
hide
)
Description:
Bug 15752: (QA follow-up) Remove unecessary redirect
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-02-09 07:14:22 UTC
Size:
1.97 KB
patch
obsolete
>From 33b2534717b5c02d5161b235fc34449471cb1c50 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Dec 2017 15:14:22 -0300 >Subject: [PATCH] Bug 15752: (QA follow-up) Remove unecessary redirect > >We are on circulation.pl, no need to redirect. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > circ/circulation.pl | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index b41f87d..46d5ec4 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -83,12 +83,18 @@ if (!C4::Context->userenv){ > > my $barcodes = []; > my $barcode = $query->param('barcode'); >+my $findborrower; >+my $autoswitched; > > if (C4::Context->preference("AutoSwitchPatron") && $barcode) { > if (Koha::Patrons->search( { cardnumber => $barcode} )->count() > 0) { >- print $query->redirect("/cgi-bin/koha/circ/circulation.pl?findborrower=$barcode&autoswitched=1"); >+ $findborrower = $barcode; >+ undef $barcode; >+ $autoswitched = 1; > } > } >+$findborrower ||= $query->param('findborrower') || q{}; >+$findborrower =~ s|,| |g; > > # Barcode given by user could be '0' > if ( $barcode || ( defined($barcode) && $barcode eq '0' ) ) { >@@ -153,9 +159,6 @@ for (@failedreturns) { $return_failed{$_} = 1; } > > my $searchtype = $query->param('searchtype') || q{contain}; > >-my $findborrower = $query->param('findborrower') || q{}; >-$findborrower =~ s|,| |g; >- > my $branch = C4::Context->userenv->{'branch'}; > > if (C4::Context->preference("DisplayClearScreenButton")) { >@@ -664,7 +667,7 @@ $template->param( > has_modifications => $has_modifications, > override_high_holds => $override_high_holds, > nopermission => scalar $query->param('nopermission'), >- autoswitched => $query->param("autoswitched"), >+ autoswitched => $autoswitched, > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15752
:
47716
|
55953
|
57015
|
66175
|
66176
|
66177
|
67037
|
67038
|
67039
|
67174
|
67175
|
67176
|
69994
|
69995
|
69996
|
70077
|
70085
|
71359
|
71360
|
71361
| 71362 |
71363