Bugzilla – Attachment 81421 Details for
Bug 15565
Place multiple item-level holds at once for the same record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off
Bug-15565-Set-found-parameter-correctly-when-Reser.patch (text/plain), 1.73 KB, created by
Alex Buckley
on 2018-10-28 18:43:54 UTC
(
hide
)
Description:
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2018-10-28 18:43:54 UTC
Size:
1.73 KB
patch
obsolete
>From c1c82556de9ef5cccd798b0f4ba826985f130019 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 19 Apr 2016 12:15:46 +0200 >Subject: [PATCH] Bug 15565: Set 'found' parameter correctly when > ReservesNeedReturns is off >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Danielle Elder <danielle@bywatersolution.com> > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> >--- > reserve/placerequest.pl | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index a07cdc6..2732ba9 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -71,13 +71,13 @@ foreach my $bibnum (@biblionumbers) { > > my @found; > >-foreach my $checkitem (@checkitems) { >- # if we have an item selectionned, and the pickup branch is the same as the holdingbranch >- # of the document, we force the value $rank and $found . >- $rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns'); >- my $item = GetItem($checkitem); >- if ( $item->{'holdingbranch'} eq $branch ){ >- push @found, 'W' unless C4::Context->preference('ReservesNeedReturns'); >+unless (C4::Context->preference('ReservesNeedReturns')) { >+ foreach my $checkitem (@checkitems) { >+ # if we have an item selectionned, and the pickup branch is the same as >+ # the holdingbranch of the document, we force the value $rank and $found >+ $rank[0] = 0; >+ my $item = GetItem($checkitem); >+ push @found, $item->{holdingbranch} eq $branch ? 'W' : undef; > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15565
:
47527
|
47551
|
47552
|
50068
|
50069
|
50392
|
50393
|
56229
|
56230
|
56231
|
56232
|
56458
|
56510
|
56511
|
56512
|
56513
|
56514
|
56515
|
56517
|
56518
|
56519
|
56520
|
56521
|
56522
|
56523
|
56524
|
61244
|
61245
|
61246
|
61247
|
61248
|
61576
|
61577
|
61578
|
61579
|
61580
|
64590
|
64591
|
64592
|
64593
|
64594
|
66594
|
66595
|
66596
|
66597
|
66598
|
68759
|
68760
|
68761
|
68762
|
68763
|
71643
|
71644
|
71645
|
71646
|
71647
|
71648
|
72644
|
72645
|
72646
|
72647
|
72648
|
72649
|
78242
|
78243
|
78244
|
78245
|
78246
|
78247
|
78248
|
78266
|
78305
|
78417
|
78418
|
78419
|
78420
|
78421
|
78422
|
78423
|
78424
|
78425
|
78426
|
78712
|
78713
|
78714
|
78715
|
78716
|
78717
|
78718
|
78719
|
78720
|
78815
|
78816
|
78817
|
78818
|
78819
|
78820
|
78821
|
78822
|
78823
|
81419
|
81420
|
81421
|
81422
|
81423
|
81424
|
81425
|
81426
|
81427
|
81431
|
81449
|
81570
|
81571
|
81572
|
81573
|
81574
|
81575
|
81576
|
81577
|
81578
|
81579
|
81580
|
81581
|
82205
|
82206
|
82207
|
82208
|
82209
|
82210
|
82211
|
82212
|
82213
|
82214
|
82215
|
82216
|
82220
|
82221
|
83331
|
83332
|
83333
|
83334
|
83335
|
83336
|
83337
|
83338
|
83339
|
83340
|
83341
|
83342
|
83378
|
83380
|
83381
|
84541
|
84542
|
84543
|
84544
|
84545
|
84546
|
84547
|
84548
|
84549
|
84550
|
84551
|
84552
|
84553
|
87979
|
87980
|
87981
|
87982
|
87983
|
87984
|
87985
|
87986
|
87987
|
87988
|
87989
|
87990
|
87991
|
117128
|
117129
|
117130
|
117131
|
117132
|
117133
|
120365
|
120366
|
120367
|
120639
|
120640
|
120641
|
121941
|
122098
|
162071
|
162072
|
162073
|
162074
|
163052
|
163053
|
163054
|
163055
|
163092
|
163093
|
166005
|
166006
|
166007
|
166008
|
166009