Bugzilla – Attachment 85318 Details for
Bug 22374
Circulation.t noisy since Bug 21753 was pushed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22374: Silence warning in UpdateFine logaction
Bug-22374-Silence-warning-in-UpdateFine-logaction.patch (text/plain), 999 bytes, created by
Martin Renvoize
on 2019-02-20 09:28:54 UTC
(
hide
)
Description:
Bug 22374: Silence warning in UpdateFine logaction
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-02-20 09:28:54 UTC
Size:
999 bytes
patch
obsolete
>From 51cb842d6c14fabb6fadf7268843bdcabd29b932 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 20 Feb 2019 09:26:38 +0000 >Subject: [PATCH] Bug 22374: Silence warning in UpdateFine logaction > >In bug 21753 we replaced the always empty variable $type with undef and >this caused noise in the Circulation.t tests. This patch replaces the >undef with the string 'UPDATE' to reflact that fine updates are taking >place. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Overdues.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 98e7bbffd4..d7c55ad0f5 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -640,7 +640,7 @@ sub UpdateFine { > # logging action > &logaction( > "FINES", >- undef, >+ "UPDATE", > $borrowernumber, > "due=".$due." amount=".$amount." itemnumber=".$itemnum > ) if C4::Context->preference("FinesLog"); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22374
:
85318
|
85451
|
85651