I missed a case in the tests!
Created attachment 85318 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85451 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
*** Bug 22356 has been marked as a duplicate of this bug. ***
Created attachment 85651 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Bug 21747 removed this code, is this still needed?
The call to logaction moves to Koha::Account::Line->adjust and it is already set to 'UPDATE' there.. This patch is no longer needed :) *** This bug has been marked as a duplicate of bug 21747 ***