Attachment 85451 Details for Bug 22374 – Bug 22374: Silence warning in UpdateFine logaction

[patch] Bug 22374: Silence warning in UpdateFine logaction

Bug-22374-Silence-warning-in-UpdateFine-logaction.patch (text/plain), 1.05 KB, created by Jonathan Druart on 2019-02-21 15:22:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-02-21 15:22:49 UTC

Size: 1.05 KB

patch

obsolete

>From 30304fe4d3421cafff8dba87ac34d5956e568748 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 20 Feb 2019 09:26:38 +0000
>Subject: [PATCH] Bug 22374: Silence warning in UpdateFine logaction
>
>In bug 21753 we replaced the always empty variable $type with undef and
>this caused noise in the Circulation.t tests. This patch replaces the
>undef with the string 'UPDATE' to reflact that fine updates are taking
>place.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Overdues.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index 98e7bbffd4..d7c55ad0f5 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -640,7 +640,7 @@ sub UpdateFine {
>     # logging action
>     &logaction(
>         "FINES",
>-        undef,
>+        "UPDATE",
>         $borrowernumber,
>         "due=".$due."  amount=".$amount." itemnumber=".$itemnum
>         ) if C4::Context->preference("FinesLog");
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22374: 85318 | 85451 | 85651