Attachment 87520 Details for Bug 12166 – Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines

[patch] Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines

Bug-12166-follow-up-Remove-Reserve-Charge-from-des.patch (text/plain), 1.54 KB, created by Owen Leonard on 2019-04-08 13:30:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-04-08 13:30:46 UTC

Size: 1.54 KB

patch

obsolete

>From efb9a15034834ee29cebe9d8c3cbb745c9a740ed Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 6 Apr 2019 12:11:38 +0000
>Subject: [PATCH] Bug 12166: (follow-up) Remove 'Reserve Charge' from
> descriptions in accountlines
>
>With the prior 'Hold fee' will be displayed in OPAC and staff, so
>the 'Reserve Charge' would just be an untranslatable double up
>of information.
>
>To test:
>- Make sure you create some Reserve Charges prior to applying this
>  patch set
>- Verify they show in staff and OPAC account
>- Apply patch
>- Run database update
>- Verfy the "Rental Charge - " is gone and old and new entries
>  match now
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> installer/data/mysql/atomicupdate/bug_12166_reserve_charge.perl | 6 ++++++
> 1 file changed, 6 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_12166_reserve_charge.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_12166_reserve_charge.perl b/installer/data/mysql/atomicupdate/bug_12166_reserve_charge.perl
>new file mode 100644
>index 0000000..508dcdd
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_12166_reserve_charge.perl
>@@ -0,0 +1,6 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    $dbh->do("UPDATE accountlines SET description = REPLACE(description, 'Reserve Charge - ', '') WHERE description LIKE 'Reserve Charge - %'");
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 12166 - Remove 'Reserve Charge' text from accountlines description)\n";
>+}
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12166: 85399 | 87423 | 87472 | 87473 | 87475 | 87478 | 87479 | 87520 | 87521 | 87584 | 87585 | 87586 | 87587