Right now, a reserve charge will display in OPAC and staff like this: Res, Reserve Charge - Administrative sanctions in the European Union / Res is the accounttype, which should be resolved into a description - Hold fee. Reserve Charge should no longer be saved to the database, description should only have the title. Ideally, existing Reserve charge entries should be cleaned up.
Why should a reserve charge not be saved to the database?
Never mind, you mean the text, not the charge itself. As you were.
Created attachment 85399 [details] [review] Bug 12166: Improve display of Reserve charges in patron account This patch makes changes to the way hold fees are recorded and displayed in the OPAC and staff client: - No English strings should be stored in the accountline description. - The accounttype code should be used to display what kind of charge it is. To test, apply the patch and go to the staff client: - Configure a patron category to have a hold fee. - Place one or more holds for a patron in that category. - On the patron's record, view Accounting -> Make a payment - There should be a separate column for "Account type" showing "Hold fee" for the hold charges. - There should be no "Res" or "Reserve Charge" text in the description column--just the title. - Switch to the "Transactions" tab. The display should be similar. - In the OPAC, log in as a patron who has hold fees on their account. - View the "your fines" page to confirm that the information is displayed correctly there as well. - Place a hold for a patron who incurs hold charges. - Log in to the self-checkout module as that patron and check out an item which will fulfill that hold. - The correct fine information should be saved to accountlines: A "Res" type with a description consisting only of the title.
*** Bug 12324 has been marked as a duplicate of this bug. ***
Hi Owen, do you plan to continue here?
I do.
Created attachment 87423 [details] [review] Bug 12166: Improve display of Reserve charges in patron account This patch makes changes to the way hold fees are recorded and displayed in the OPAC and staff client: - No English strings should be stored in the accountline description. - The accounttype code should be used to display what kind of charge it is. To test, apply the patch and go to the staff client: - Configure a patron category to have a hold fee. - Place one or more holds for a patron in that category. - On the patron's record, view Accounting -> Make a payment - There should be a separate column for "Account type" showing "Hold fee" for the hold charges. - There should be no "Res" or "Reserve Charge" text in the description column--just the title. - Switch to the "Transactions" tab. The display should be similar. - In the OPAC, log in as a patron who has hold fees on their account. - View the "your fines" page to confirm that the information is displayed correctly there as well. - Place a hold for a patron who incurs hold charges. - Log in to the self-checkout module as that patron and check out an item which will fulfill that hold. - The correct fine information should be saved to accountlines: A "Res" type with a description consisting only of the title.
Created attachment 87472 [details] [review] Bug 12166: Improve display of Reserve charges in patron account This patch makes changes to the way hold fees are recorded and displayed in the OPAC and staff client: - No English strings should be stored in the accountline description. - The accounttype code should be used to display what kind of charge it is. To test, apply the patch and go to the staff client: - Configure a patron category to have a hold fee. - Place one or more holds for a patron in that category. - On the patron's record, view Accounting -> Make a payment - There should be a separate column for "Account type" showing "Hold fee" for the hold charges. - There should be no "Res" or "Reserve Charge" text in the description column--just the title. - Switch to the "Transactions" tab. The display should be similar. - In the OPAC, log in as a patron who has hold fees on their account. - View the "your fines" page to confirm that the information is displayed correctly there as well. - Place a hold for a patron who incurs hold charges. - Log in to the self-checkout module as that patron and check out an item which will fulfill that hold. - The correct fine information should be saved to accountlines: A "Res" type with a description consisting only of the title. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87473 [details] [review] Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now
Hi Owen, love the patch, this is so much better. Could you take a look at my follow-up?
Created attachment 87475 [details] [review] Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content
Created attachment 87478 [details] [review] Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now
Created attachment 87479 [details] [review] Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content
Created attachment 87520 [details] [review] Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87521 [details] [review] Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87584 [details] [review] Bug 12166: Improve display of Reserve charges in patron account This patch makes changes to the way hold fees are recorded and displayed in the OPAC and staff client: - No English strings should be stored in the accountline description. - The accounttype code should be used to display what kind of charge it is. To test, apply the patch and go to the staff client: - Configure a patron category to have a hold fee. - Place one or more holds for a patron in that category. - On the patron's record, view Accounting -> Make a payment - There should be a separate column for "Account type" showing "Hold fee" for the hold charges. - There should be no "Res" or "Reserve Charge" text in the description column--just the title. - Switch to the "Transactions" tab. The display should be similar. - In the OPAC, log in as a patron who has hold fees on their account. - View the "your fines" page to confirm that the information is displayed correctly there as well. - Place a hold for a patron who incurs hold charges. - Log in to the self-checkout module as that patron and check out an item which will fulfill that hold. - The correct fine information should be saved to accountlines: A "Res" type with a description consisting only of the title. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87585 [details] [review] Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87586 [details] [review] Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87587 [details] [review] Bug 12166: (QA follow-up) Update test for description Update the relevant test to check for 'description eq title' as aposed to the old 'description eq "Reserve Charge - title"'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice fix, no regressions and passes the QA scripts and I've added a followup for you to correct the failing test. Passing QA
Dependencies seem a bit weird.. this patch happily applies without bug 11573.
Awesome work all! Pushed to master for 19.05
Non-trivial backport for long standing bug, choosing not to backport due to risk for regressions.
*** Bug 11971 has been marked as a duplicate of this bug. ***
*** Bug 18352 has been marked as a duplicate of this bug. ***