Bugzilla – Attachment 92775 Details for
Bug 23272
Koha::AuthorisedValue should use Koha::Object::Limit::Library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23272: (RM followup) Fix failing tests
Bug-23272-RM-followup-Fix-failing-tests.patch (text/plain), 1.49 KB, created by
Martin Renvoize
on 2019-09-13 10:22:17 UTC
(
hide
)
Description:
Bug 23272: (RM followup) Fix failing tests
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-09-13 10:22:17 UTC
Size:
1.49 KB
patch
obsolete
>From 9515677afa2d6823016b3351fddbc45930c21667 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 13 Sep 2019 11:19:28 +0100 >Subject: [PATCH] Bug 23272: (RM followup) Fix failing tests > >This bug introduced a regression whereby if any authorized value has no >branch limitations then the authorized value administration page would >fail to display at all. > >A simple ternary corrects the issue, but I'm now wondering about the >logic of returning 'undef' from 'get_branch_limits'.. perhaps an empty >(or full) resultset might be a better option to prevent us from >requireing ternaries before calling chained methods on such objects. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > admin/authorised_values.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/authorised_values.pl b/admin/authorised_values.pl >index 6080dbb640..3e23426b18 100755 >--- a/admin/authorised_values.pl >+++ b/admin/authorised_values.pl >@@ -231,7 +231,7 @@ if ( $op eq 'list' ) { > $row_data{lib} = $av->lib; > $row_data{lib_opac} = $av->lib_opac; > $row_data{imageurl} = getitemtypeimagelocation( 'intranet', $av->imageurl ); >- $row_data{branches} = $av->library_limits->as_list; >+ $row_data{branches} = $av->library_limits ? $av->library_limits->as_list : []; > $row_data{id} = $av->id; > push(@loop_data, \%row_data); > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23272
:
91368
|
91369
|
91462
|
91463
|
92768
|
92769
| 92775 |
93197