Bug 23272 - Koha::AuthorisedValue should use Koha::Object::Limit::Library
Summary: Koha::AuthorisedValue should use Koha::Object::Limit::Library
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 23281 17755
Blocks:
  Show dependency treegraph
 
Reported: 2019-07-05 18:51 UTC by Tomás Cohen Arazi
Modified: 2019-07-11 10:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library (3.56 KB, patch)
2019-07-05 19:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 23272: Adapt controller and tests (5.42 KB, patch)
2019-07-05 19:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library (3.63 KB, patch)
2019-07-11 10:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 23272: Adapt controller and tests (5.49 KB, patch)
2019-07-11 10:29 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2019-07-05 18:51:07 UTC
Koha::Patron::Attribute::Type should be used as example.
Comment 1 Tomás Cohen Arazi 2019-07-05 19:26:27 UTC
Created attachment 91368 [details] [review]
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library
Comment 2 Tomás Cohen Arazi 2019-07-05 19:26:33 UTC
Created attachment 91369 [details] [review]
Bug 23272: Adapt controller and tests

This patch adapts the controller script for handling authorised values,
and the tests to reflect the method names changes.

To test:
- Verify you can add/delete/edit authorised values with/without branch
limitations, as usual
=> SUCCESS: All works as usual!
- Run:
  $ kshell
 k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
- Sign off :-D
Comment 3 Kyle M Hall 2019-07-11 10:29:29 UTC
Created attachment 91462 [details] [review]
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall 2019-07-11 10:29:38 UTC
Created attachment 91463 [details] [review]
Bug 23272: Adapt controller and tests

This patch adapts the controller script for handling authorised values,
and the tests to reflect the method names changes.

To test:
- Verify you can add/delete/edit authorised values with/without branch
limitations, as usual
=> SUCCESS: All works as usual!
- Run:
  $ kshell
 k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>