Description
Kyle M Hall
2013-04-10 17:45:01 UTC
Created attachment 17348 [details] [review] Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Created attachment 17349 [details] [review] Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Created attachment 17354 [details] [review] Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 17355 [details] [review] Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This is better, but not quite there yet. I have checked the print for a partially paid fine and it still shows the full amount instead of the amount left to pay. Upping bug severity a bit. Created attachment 20812 [details] [review] Bug 10027 - Fine details not showing when printing a fine - QA Followup I think this works as intended now, but it would be good if all fine lines showed not just the one you clicked - that would make more sense of the total given. Created attachment 20851 [details] [review] [PASSED QA] Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on third patch. Created attachment 20852 [details] [review] [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 20853 [details] [review] [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - QA Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Checked invoice is correctly printed for - partially paid fines - paid fines - unpaid fines Pushed to master. Thanks, Kyle! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! |