Bug 10028

Summary: ModReceiveOrder works unexpectedly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: AcquisitionsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: bgkriegel, gmcharlt, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10028: ModReceiveOrder unexpectedly works.
Bug 10028: ModReceiveOrder unexpectedly works.
Bug 10028: ModReceiveOrder unexpectedly works.

Description Jonathan Druart 2013-04-11 13:28:40 UTC

    
Comment 1 Jonathan Druart 2013-04-11 13:29:39 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-08-09 01:15:19 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-08-16 12:56:01 UTC
Created attachment 20405 [details] [review]
Bug 10028: ModReceiveOrder unexpectedly works.

In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used.

NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the
ordernumber is got with
  my $ordernumber = NewOrder( $args );

It works because:
sub t{
    return ("a", "b");
}
my $a = t();
say $a;

Will display 'b'.

But it is not really clear.

Test plan:
Check that there is no regression for partial receives.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-08-16 16:59:55 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi 2013-09-13 14:33:36 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!
Comment 6 Bernardo Gonzalez Kriegel 2013-09-14 22:40:40 UTC
Pushed to 3.10.x, will be in 3.10.11