| Summary: | Small improvements on serial missinglist and receivedlist | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Serials | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED WONTFIX | QA Contact: | Paul Poulain <paul.poulain> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | colin.campbell, gitbot, jonathan.druart, koha.aixmarseille, paul.poulain, sandboxes |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 8896 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10092: Small improvements on serial missinglist and receivedlist
Bug 10092 Followup for NewIssue Bug 10092: Small improvements on serial missinglist and receivedlist Bug 10092 Followup for NewIssue Bug 10092: Small improvements on serial missinglist and receivedlist Bug 10092 Followup for NewIssue |
||
|
Description
Marcel de Rooy
2013-04-22 10:02:34 UTC
This patch also removes the "not issued "-string from the missing list. The issue is marked as not available and therefore missing. The status field is sufficient. The additional text was not cleared in the past when the missing status was changed to another status. Optionally, we could even add a db rev to get rid of all "not issued "-occurrences in all missinglist's. What do you think? I did not add it at this moment.. Created attachment 17576 [details] [review] Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). Created attachment 17580 [details] [review] Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. This patch adds the "not available" or "missing" at the missing list. He adds the "received" at the received list. It works even when I change status. The missing list and the received list are OK. Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> Created attachment 21960 [details] [review] Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Created attachment 21961 [details] [review] Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> QA comment: * passes koha-qa.pl * works fine, except for the following glitch: let's suppose you've issue #100 missing, and #99 #101 recieved. When you change the #100 status because you get it, the receivedlist will be #99; #101; #100, which is not perfect. But it's better than previously, so passing QA Created attachment 22246 [details] [review] Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Created attachment 22247 [details] [review] Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> And yet another patch (from April 22 !!) down the drain.. Marcel, What did you mark this bug report as won't fix? The question is "Why", not "What" :) (In reply to Jonathan Druart from comment #13) > Marcel, > What did you mark this bug report as won't fix? Giving up on rebasing these patches.. |