Bug 10092 - Small improvements on serial missinglist and receivedlist
Summary: Small improvements on serial missinglist and receivedlist
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Paul Poulain
URL:
Keywords:
Depends on: 8896
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-22 10:02 UTC by Marcel de Rooy
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10092: Small improvements on serial missinglist and receivedlist (2.46 KB, patch)
2013-04-22 10:14 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10092 Followup for NewIssue (4.73 KB, patch)
2013-04-22 11:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10092: Small improvements on serial missinglist and receivedlist (2.48 KB, patch)
2013-10-11 10:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 10092 Followup for NewIssue (4.75 KB, patch)
2013-10-11 10:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 10092: Small improvements on serial missinglist and receivedlist (2.54 KB, patch)
2013-10-22 00:11 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 10092 Followup for NewIssue (4.80 KB, patch)
2013-10-22 00:11 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-04-22 10:02:34 UTC
Followup report for bug 8896 updating missinglist.
Similar changes should be made to receivedlist (note that unfortunately this field is called recievedlist in the database).
Comment 1 Marcel de Rooy 2013-04-22 10:07:41 UTC
This patch also removes the "not issued "-string from the missing list. The issue is marked as not available and therefore missing. The status field is sufficient. The additional text was not cleared in the past when the missing status was changed to another status.
Comment 2 Marcel de Rooy 2013-04-22 10:09:40 UTC
Optionally, we could even add a db rev to get rid of all "not issued "-occurrences in all missinglist's.
What do you think?
I did not add it at this moment..
Comment 3 Marcel de Rooy 2013-04-22 10:14:54 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-04-22 11:49:44 UTC Comment hidden (obsolete)
Comment 5 Koha Team AMU 2013-10-11 10:18:08 UTC
This patch adds the "not available" or "missing" at the missing list. He adds the "received" at the received list. It works even when I change status.
The missing list and the received list are OK.
Comment 6 Biblibre Sandboxes 2013-10-11 10:18:14 UTC
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com>
Comment 7 Biblibre Sandboxes 2013-10-11 10:18:43 UTC Comment hidden (obsolete)
Comment 8 Biblibre Sandboxes 2013-10-11 10:18:46 UTC Comment hidden (obsolete)
Comment 9 Paul Poulain 2013-10-22 00:07:54 UTC
QA comment:
 * passes koha-qa.pl
 * works fine, except for the following glitch: let's suppose you've issue #100 missing, and #99 #101 recieved. When you change the #100 status because you get it, the receivedlist will be #99; #101; #100, which is not perfect. But it's better than previously, so passing QA
Comment 10 Paul Poulain 2013-10-22 00:11:10 UTC
Created attachment 22246 [details] [review]
Bug 10092: Small improvements on serial missinglist and receivedlist

Builds upon report 8896 with changes for missinglist.
Similar changes for receivedlist to be consistent.

Test plan:
Go to serial collection information.
Edit serials.
Toggle the status through all possible values.
On another tab or in the db, check missinglist and receivedlist (subscription
detail tab Summary).

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 11 Paul Poulain 2013-10-22 00:11:19 UTC
Created attachment 22247 [details] [review]
Bug 10092 Followup for NewIssue

Same logic for new issue.
Moves the shared code to a local subroutine.

Test plan:
Add an issue via Generate Next button. No changes to missing and received.
Now add an issue via Edit Serials and Supplemental issue with status Arrived.
Check the received list.
Now add supplemental issue with status Missing or Not available.
Check the missing list.

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 12 Marcel de Rooy 2013-10-31 09:01:49 UTC
And yet another patch (from April 22 !!) down the drain..
Comment 13 Jonathan Druart 2014-02-13 08:36:38 UTC
Marcel,
What did you mark this bug report as won't fix?
Comment 14 Jonathan Druart 2014-02-13 08:58:47 UTC
The question is "Why", not "What" :)
Comment 15 Marcel de Rooy 2014-02-13 09:07:04 UTC
(In reply to Jonathan Druart from comment #13)
> Marcel,
> What did you mark this bug report as won't fix?

Giving up on rebasing these patches..