| Summary: | opacbookbag shouldn't prevent from adding items to a list in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | OPAC | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC
[SIGNED-OFF] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent... Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC |
||
|
Description
Tomás Cohen Arazi (tcohen)
2013-04-24 14:16:42 UTC
I confirm this in both 'prog' and 'ccsr' (In reply to comment #1) > I confirm this in both 'prog' and 'ccsr' Also only a bug on the search results page, in the detail page it works as expected. Created attachment 17656 [details] [review] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Tomas: Via this report I connect to the encoding stuff: Search for something with diacritics. Try to add it to a list with bookbag disabled. You will see a mangled search expression without results and no item added. Created attachment 17659 [details] [review] [SIGNED-OFF] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 17665 [details] [review] PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent... (In reply to comment #4) > Tomas: > Via this report I connect to the encoding stuff: Search for something with > diacritics. Try to add it to a list with bookbag disabled. You will see a > mangled search expression without results and no item added. Bug 10114 is created for this new bug. Created attachment 17675 [details] [review] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only patch, works nicely. Test plan copied from bug report: - Disable the opacbookbag syspref - Login in the OPAC - Create a list (I tested a private one) - Search in your db for some biblios. - Choose some and add them to the created list - Go to your users's page, to the my lists tab - Your list is empty. I cannot reproduce this problem. Is there anything else I might need to know? However, when I disable the opacbookbag syspref all the other javascript on the page breaks. I did my test in CCSR and it worked like described. There was still a [News list] link in the dropdown on top of the result list, but if you clicked on it, nothing happened. After applying the patch and reloading the patch the normal popup came up and it worked nicely. This patch has been pushed to master and 3.12.x. I was unable to replicate the problem, but this patch did not make things worse for me and fixed things for others so I have pushed anyway. Created attachment 17729 [details] [review] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only patch, works nicely. Test plan copied from bug report: - Disable the opacbookbag syspref - Login in the OPAC - Create a list (I tested a private one) - Search in your db for some biblios. - Choose some and add them to the created list - Go to your users's page, to the my lists tab - Your list is empty. Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 |