| Summary: | Remove deprecated Z39.50.pm code | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Galen Charlton <gmcharlt> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Looks like you are right about it. Please do not forget some references in the unit tests (also in your grep). (In reply to comment #1) > Looks like you are right about it. Please do not forget some references in > the unit tests (also in your grep). Thanks for pointing that out, Marcel. I was going to comment on that but forgot. I figure that unit test in the grep could just be removed all together, although there are likely references to it somewhere in the installer directory (which I excluded just because it was flooding my screen with seemingly irrelevant matches). I'll have to make sure to be thorough. The more deprecated code gone, the better :) |
I think that Z39.50.pm is all deprecated code and that it can safely be removed. I grepped for a reference to it, and only noticed references in Makefile and Makefile.old. When I grepped for the subs in the module, I only found references within the same module: grep -R -i "getz3950servers" * --exclude-dir="translator" --exclude-dir="installer" --exclude-dir="ar-Arab" --exclude-dir="fr-FR" --exclude-dir="blib" C4/Z3950.pm: &getz3950servers C4/Z3950.pm:=item getz3950servers C4/Z3950.pm: @servers= &getz3950servers(checked); C4/Z3950.pm:sub getz3950servers { t/db_dependent/lib/KohaTest/Z3950.pm: my @methods = qw( getz3950servers C4/Z3950.pm: &z3950servername C4/Z3950.pm:=item z3950servername C4/Z3950.pm: $name = &z3950servername($dbh, $server_id, $default_name); C4/Z3950.pm:sub z3950servername { C4/Z3950.pm:} # sub z3950servername t/db_dependent/lib/KohaTest/Z3950.pm: z3950servername C4/Z3950.pm: &addz3950queue C4/Z3950.pm:=item addz3950queue C4/Z3950.pm: $errmsg = &addz3950queue($query, $type, $request_id, @servers); C4/Z3950.pm:C<&addz3950queue> sends a SIGHUP to the daemon to tell it to process C4/Z3950.pm:C<&addz3950queue> returns an error message. If it was successful, the C4/Z3950.pm:sub addz3950queue { C4/Z3950.pm:} # sub addz3950queue t/db_dependent/lib/KohaTest/Z3950.pm: addz3950queue C4/Z3950.pm: &checkz3950searchdone C4/Z3950.pm:=item &checkz3950searchdone C4/Z3950.pm: $numberpending= & &checkz3950searchdone($random); C4/Z3950.pm:sub checkz3950searchdone { t/db_dependent/lib/KohaTest/Z3950.pm: checkz3950searchdone