| Summary: | If an item isn't editable, don't show the onclick Edit/Delete menu | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, m.de.rooy, nengard, vfernandes |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu
[SIGNED-OFF] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu [PASSED QA] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu |
||
|
Description
Owen Leonard
2013-05-09 19:07:22 UTC
Created attachment 18050 [details] [review] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. Created attachment 18076 [details] [review] [SIGNED-OFF] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test pass Created attachment 18092 [details] [review] [PASSED QA] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Changes to the templates include no string changes. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 *** Bug 6802 has been marked as a duplicate of this bug. *** |