Summary: | Link to patron files missing from circ-menu.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/members/pay.pl?borrowernumber=96 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10261 - Link to patron files missing from circ-menu.tt
Bug 10261 [Revised] Link to patron files missing from circ-menu.tt [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt Bug 10261 [Revised] Link to patron files missing from circ-menu.tt |
Description
Nicole C. Engard
2013-05-16 17:29:13 UTC
Created attachment 18209 [details] [review] Bug 10261 - Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. See Bug 9917 for the solution to the problem with the routing lists link. I can't reproduce the problem with the statistics link in master or 3.10.x. The link is there now but the link doesn't include the borrowernumber so it doesn't open right: /cgi-bin/koha/members/files.pl?borrowernumber= Created attachment 18248 [details] [review] Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Created attachment 18249 [details] [review] [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass QA comment: I never understand why 2 includes files are present. What is the way to keep just one of them? The patch fixes the described issue. Marked as Passed QA. Created attachment 18306 [details] [review] Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass (In reply to comment #6) > QA comment: > > I never understand why 2 includes files are present. What is the way to keep > just one of them? I would agree that moving towards DRY (don't repeat yourself) would nice. Regardless, I've pushed this to master. Thanks, Owen! (In reply to comment #6) > I never understand why 2 includes files are present. What is the way to keep > just one of them? From the original commit of that file: "Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables." http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=507c7f422485aaf7ae601b0a84bacdbaedac061c Perhaps there is a better way to handle the scope issue? This patch has been pushed to 3.12.x, will be in 3.12.1. |