Description
Jonathan Druart
2013-05-17 13:08:05 UTC
Created attachment 18197 [details] [review] MT10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Created attachment 18251 [details] [review] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS I am not sure this one is right. It looks like the DelOrder calls are hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't make sense to me. Should it perhaps be DelOrder($biblionumber1, $ordernumber1) ... etc.? Setting to In Discussion in case I am misunderstanding the code. (In reply to comment #3) > I am not sure this one is right. It looks like the DelOrder calls are > hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't > make sense to me. Should it perhaps be DelOrder($biblionumber1, > $ordernumber1) ... etc.? Yes, of course! I will provide a new patch. Thanks! Created attachment 18661 [details] [review] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS This looks better, but the bookseller is not getting deleted at the end of the run. (In reply to comment #6) > This looks better, but the bookseller is not getting deleted at the end of > the run. :-/ Did you get an error? It should be deleted, DelBookseller is called into the END block. Created attachment 18976 [details] [review] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. I tried again and this time it worked. I must not have applied the latest patch last time. Created attachment 19405 [details] [review] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. Created attachment 19406 [details] [review] Bug 10274: Execute sql queries into a transaction Created attachment 19620 [details] [review] [PASSED QA] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. Created attachment 19621 [details] [review] [PASSED QA] Bug 10274: Execute sql queries into a transaction Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! This does not apply cleanly to 3.10.x |