Bug 10403 - Add ability to set fund/budget on receipt
Summary: Add ability to set fund/budget on receipt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jared Camins-Esakov
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 10274
Blocks: 11221
  Show dependency treegraph
 
Reported: 2013-06-04 16:22 UTC by Jared Camins-Esakov
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10403: add ability to change fund on receipt (10.63 KB, patch)
2013-06-16 19:56 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10403: add ability to change fund on receipt (10.54 KB, patch)
2013-08-13 12:48 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10403: Show inactive but unlocked budgets on orderreceive (3.04 KB, patch)
2013-08-13 12:48 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[PATCH][SIGNED OFF] Bug 10403: add ability to change fund on receipt (10.61 KB, patch)
2013-09-13 21:05 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH][SIGNED OFF] Bug 10403: Show inactive but unlocked budgets on orderreceive (3.12 KB, patch)
2013-09-13 21:08 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 10403: add ability to change fund on receipt (10.66 KB, patch)
2013-09-19 10:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10403: Show inactive but unlocked budgets on orderreceive (3.19 KB, patch)
2013-09-19 10:40 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-06-04 16:22:57 UTC
Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This development will add the ability to change the budget and fund when receiving.
Comment 1 Jared Camins-Esakov 2013-06-16 19:56:04 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2013-08-13 12:48:16 UTC Comment hidden (obsolete)
Comment 3 Jared Camins-Esakov 2013-08-13 12:48:25 UTC Comment hidden (obsolete)
Comment 4 Mathieu Saby 2013-09-13 21:01:57 UTC
Thanks, it will very useful. Works as described, I sign off.

One remark : on "invoice.pl" after the reception is done, there is a column "fund" in the table. Now that we can use a fund from an inactive budget, maybe we could add a column budget, or just give the name of the budget in parenthesis after the fund?
(just an idea...)

By the way, I think the table invoice.pl does not take into account the unitprice, but the ecost. That's bad...

Mathieu
Comment 5 Mathieu Saby 2013-09-13 21:05:51 UTC Comment hidden (obsolete)
Comment 6 Mathieu Saby 2013-09-13 21:08:19 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-09-19 10:39:46 UTC
QA comment:

Works great. I tested some receives and results are consistent.

The budgets dropdown list construction should really be factorized. Sometimes it is displayed with budgets, sometimes not. Sometimes a checkbox is there for displaying all funds, sometimes not.

Marked as Passed QA.
Comment 8 Jonathan Druart 2013-09-19 10:40:06 UTC
Created attachment 21231 [details] [review]
Bug 10403: add ability to change fund on receipt

Right now there is no way to change the budget or fund when receiving an
item, which is annoying, particularly at the end of the fiscal year when
every item not already received has to be switched to the following
year's budget. This patch adds the ability to change the budget and fund
when receiving.

To test:
1) Apply patch.
2) Create an order for a vendor, choosing a fund to use for that order.
3) Receive the order, leaving the fund unchanged. Make sure the fund
   did not change.
4) Create another order for a vendor, choosing a fund to use for that
   order.
5) Receive the order, this time changing the fund. Make sure the fund
   is changed.
6) Run the unit test:
    > prove t/db_dependent/Acquisition.t
7) Sign off.

(Notes: this patch depends on the Acquisitions.t unit test improvements
in bug 10274; the seemingly-unrelated change in SQLHelper quiets an
irritating warning caused by the NewOrder call in ModReceiveOrder)

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Jonathan Druart 2013-09-19 10:40:11 UTC
Created attachment 21232 [details] [review]
Bug 10403: Show inactive but unlocked budgets on orderreceive

I have heard from several libraries that at the end of the budget
year even though a budget is inactive for new acquisitions, an
inactive budget should remain modifiable until the books are
closed and the budget is marked inactive. This patch makes it so
that all budgets that are unlocked are available on the order
receipt page (only).

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 10 Galen Charlton 2013-10-22 13:01:35 UTC
Pushed to master.  Thanks, Jared!