| Summary: | UT: OrderFromSubscription.t needs to create its own data | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 10273 | ||
| Attachments: |
MT10275: UT: OrderFromSubscription.t needs to create its own data
Bug 10275: UT: OrderFromSubscription.t needs to create its own data Bug 10275: UT: OrderFromSubscription.t needs to create its own data Bug 10275: Use a transaction for OrderFromSubscription.t [PASSED QA] Bug 10275: UT: OrderFromSubscription.t needs to create its own data [PASSED QA] Bug 10275: Use a transaction for OrderFromSubscription.t |
||
|
Description
Jonathan Druart
2013-05-17 13:26:54 UTC
Created attachment 18201 [details] [review] MT10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... Created attachment 18252 [details] [review] Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... Im signing off on this, but a follow up adding a transaction would be more than welcome Created attachment 19286 [details] [review] Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 19306 [details] [review] Bug 10275: Use a transaction for OrderFromSubscription.t Created attachment 19622 [details] [review] [PASSED QA] Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests. Assumes Dateformat is set to US dates as in the sample data. Created attachment 19623 [details] [review] [PASSED QA] Bug 10275: Use a transaction for OrderFromSubscription.t Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! |