Bug 10275 - UT: OrderFromSubscription.t needs to create its own data
Summary: UT: OrderFromSubscription.t needs to create its own data
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 10273
  Show dependency treegraph
 
Reported: 2013-05-17 13:26 UTC by Jonathan Druart
Modified: 2014-12-07 20:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
MT10275: UT: OrderFromSubscription.t needs to create its own data (3.20 KB, patch)
2013-05-17 13:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10275: UT: OrderFromSubscription.t needs to create its own data (3.20 KB, patch)
2013-05-20 14:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10275: UT: OrderFromSubscription.t needs to create its own data (3.25 KB, patch)
2013-06-30 04:22 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10275: Use a transaction for OrderFromSubscription.t (1.49 KB, patch)
2013-07-01 08:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10275: UT: OrderFromSubscription.t needs to create its own data (3.39 KB, patch)
2013-07-14 08:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10275: Use a transaction for OrderFromSubscription.t (1.55 KB, patch)
2013-07-14 08:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-05-17 13:26:54 UTC
t/db_dependent/Acquisition/OrderFromSubscription.t depends on the Jenkins database.
We should create the data we want and delete them at the end.
Comment 1 Jonathan Druart 2013-05-17 13:29:16 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-05-20 14:41:55 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-06-30 04:20:53 UTC
Im signing off on this, but a follow up adding a transaction would be more than welcome
Comment 4 Chris Cormack 2013-06-30 04:22:47 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-07-01 08:11:28 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-07-14 08:43:21 UTC
Created attachment 19622 [details] [review]
[PASSED QA] Bug 10275: UT: OrderFromSubscription.t needs to create its own data

Try before the patch:
prove t/db_dependent/Acquisition/OrderFromSubscription.t

And after, it should produce:
  t/db_dependent/Acquisition/OrderFromSubscription.t .. ok
  All tests successful.
  Files=1, Tests=12,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.46 cusr
  0.02 csys =  0.50 CPU)
  Result: PASS

And some warnings...

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests.
Assumes Dateformat is set to US dates as in the sample data.
Comment 7 Katrin Fischer 2013-07-14 08:43:35 UTC
Created attachment 19623 [details] [review]
[PASSED QA] Bug 10275: Use a transaction for OrderFromSubscription.t

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 8 Galen Charlton 2013-07-16 14:23:11 UTC
Pushed to master.  Thanks, Jonathan!
Comment 9 Tomás Cohen Arazi 2013-07-25 17:13:22 UTC
This patch has been pushed to 3.12.x, will be in 3.12.3.

Thanks Jonathan!