Summary: | Misleading Variable names in batchMod.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Architecture, internals, and plumbing | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
proposed patch
Updated patch [SIGNED-OFF] Bug 10291: Clarify misleading variable name Bug 10291: Clarify misleading variable name |
Description
Colin Campbell
2013-05-20 15:54:16 UTC
Created attachment 18259 [details] [review] proposed patch It looks pointless to me to have hashrefs with only one key 'itemnumber'. Would you consider changing those arrays to be pure itemnumbers please, while you're at it? (In reply to comment #2) > It looks pointless to me to have hashrefs with only one key 'itemnumber'. > Would you consider changing those arrays to be pure itemnumbers please, > while you're at it? Yes in fact that simplifies the patch. Will post an update Created attachment 18629 [details] [review] Updated patch Simplified the patch by not processing an array to look like a hash just to save a variable name. Passes an array of itemnumbers as exactly that Created attachment 18634 [details] [review] [SIGNED-OFF] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan <srdjan@catalyst.net.nz> QA comment: Variable renaming. Need to modify the max amount of items (l. 113) and see the html code source for testing this patch. No regression, no change detected. Marked as Passed QA. Created attachment 19076 [details] [review] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Colin! |