batchMod,pl has two variables with names of the form x_hashref but both are actually references to an array of hashrefs. It passes the contents of one to the templares under the name itemnumbers_hashref but the use of it belies that name. For the sake of future maintainers lets clean up these names
Created attachment 18259 [details] [review] proposed patch
It looks pointless to me to have hashrefs with only one key 'itemnumber'. Would you consider changing those arrays to be pure itemnumbers please, while you're at it?
(In reply to comment #2) > It looks pointless to me to have hashrefs with only one key 'itemnumber'. > Would you consider changing those arrays to be pure itemnumbers please, > while you're at it? Yes in fact that simplifies the patch. Will post an update
Created attachment 18629 [details] [review] Updated patch Simplified the patch by not processing an array to look like a hash just to save a variable name. Passes an array of itemnumbers as exactly that
Created attachment 18634 [details] [review] [SIGNED-OFF] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
QA comment: Variable renaming. Need to modify the max amount of items (l. 113) and see the html code source for testing this patch. No regression, no change detected. Marked as Passed QA.
Created attachment 19076 [details] [review] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Colin!