Description
Katrin Fischer
2013-05-27 12:32:54 UTC
Created attachment 20378 [details] [review] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Created attachment 20384 [details] [review] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Liz Rea <liz@catalyst.net.nz> All cases tested. I like this change, much clearer. QA comment: Owen, the label is wrong. Currently, the "add multiple copies" does not add additional copies but the total amount of items. e.g. if I enter 3, it adds the first item + 2 copies. Following your test plan, it should 1 + 3 copies. I will provide a followup in order to scroll at bottom after clicking on the "add multiple copies" button. Marked as Failed QA. Created attachment 20394 [details] [review] Bug 10347: Scroll down clicking on the "Add multiple copies" button (In reply to Jonathan Druart from comment #3) > e.g. if I enter 3, it adds the first item + 2 copies. Following your test > plan, it should 1 + 3 copies. Are you sure? I definitely get 1 + 3 copies. That's not how it has worked for me in the past - it has only added the number in the box ... so that might be a bug. (In reply to Owen Leonard from comment #5) > Are you sure? I definitely get 1 + 3 copies. ...and I seem to be the only one for whom this is true. I'll have to do more investigation to find out why. Created attachment 25463 [details] [review] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Created attachment 25464 [details] [review] [SIGNED-OFF] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested this patch and have two remarks : - If the barcode entered in the item to duplicate is already used in db it is incremented and so are the multiple items duplicated (no duplicate warning); - why is barcode created if system preference 'autobarcode' is turned to off ? Hm, just read your comment and would like to say that our libraries are not using autobarcode, but they still see it as kind of a nice feature that the barcoe incremrents when adding multiple. They are using barcode schemas not available in autobarcode, but it still works for them. (In reply to jmbroust from comment #10) > - If the barcode entered in the item to duplicate is already used in db it > is incremented and so are the multiple items duplicated (no duplicate > warning); > - why is barcode created if system preference 'autobarcode' is turned to off > ? Are these regressions caused by this patch or could they be put into separate bugs? Created attachment 48732 [details] [review] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Created attachment 48733 [details] [review] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patches rebased. Applying: Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). Repository lacks necessary blobs to fall back on 3-way merge. I forgot to obsolete the first patch. Created attachment 49905 [details] [review] [SIGNED-OFF] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, tried adding one, one & dup, multiple and cancel multiple No errors Created attachment 49906 [details] [review] [SIGNED-OFF] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 49934 [details] [review] [PASSED QA] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, tried adding one, one & dup, multiple and cancel multiple No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 49935 [details] [review] [PASSED QA] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! |