Summary: | Second click on modification log misses object parameter | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 6911 | ||
Bug Blocks: | |||
Attachments: |
Bug 10355: paramater 'object' lost on the road
[SIGNED-OFF] Bug 10355: paramater 'object' lost on the road [PASSED QA] Bug 10355: paramater 'object' lost on the road |
Description
Katrin Fischer
2013-05-27 16:49:56 UTC
(In reply to Katrin Fischer from comment #0) > To reproduce the problem: > > 1) Go to any detail page in staff > 2) Click on the modification log tab > 3) Verify, that the object is prefilled with the records biblionumber and > you can also see it as parameter in the url > 4) Click a second time on modification log to reset your search I am not sure this is still valid, when I am on tools/viewlog.pl, I don't see the "modification log" tab, I see the menu from the tools module. Hi Jonathan, I just treid in 3.18.5.1: The trick is, that you need to access it from the detail page of a record, not from the tools start page. (In reply to Jonathan Druart from comment #1) > (In reply to Katrin Fischer from comment #0) > > To reproduce the problem: > > > > 1) Go to any detail page in staff > > 2) Click on the modification log tab > > 3) Verify, that the object is prefilled with the records biblionumber and > > you can also see it as parameter in the url > > 4) Click a second time on modification log to reset your search > > I am not sure this is still valid, when I am on tools/viewlog.pl, I don't > see the "modification log" tab, I see the menu from the tools module. That was a bug, see bug 6911 comment 6. Created attachment 37964 [details] [review] Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. It depends on the fix I submitted on bug 6911 comment 7. Created attachment 39259 [details] [review] [SIGNED-OFF] Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors http://bugs.koha-community.org/show_bug.cgi?id=10335 Created attachment 39717 [details] [review] [PASSED QA] Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors http://bugs.koha-community.org/show_bug.cgi?id=10335 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.1 Patch pushed to 3.18.x will be in 3.18.08 Pushed to 3.16.x, will be in 3.16.13 |