Summary: | CCSR theme should apply jqTransform after OpacUserJS | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | OPAC | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, jonathan.druart, mirko, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10359: transform masthead dropdown after user JS for CCSR
Bug 10359: transform masthead dropdown after user JS for CCSR Bug 10359: transform masthead dropdown after user JS for CCSR |
Description
Jared Camins-Esakov
2013-05-28 11:44:04 UTC
Created attachment 18419 [details] [review] Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Created attachment 18440 [details] [review] Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> QA comment: Just move a js line some lines before. No regression possible. Marked as Passed QA. Created attachment 18451 [details] [review] Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Jared! This patch has been pushed to 3.12.x, will be in 3.12.1. Pushed to 3.10.x, will be in 3.10.7 |